mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
45 lines
1.3 KiB
TypeScript
45 lines
1.3 KiB
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
import { expect } from '@playwright/test'
|
|
import path from 'path'
|
|
|
|
import type {
|
|
TemplateInfo,
|
|
WorkflowTemplates
|
|
} from '@/platform/workflow/templates/types/template'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
export class ComfyTemplates {
|
|
readonly content: Locator
|
|
readonly allTemplateCards: Locator
|
|
|
|
constructor(readonly page: Page) {
|
|
this.content = page.getByTestId(TestIds.templates.content)
|
|
this.allTemplateCards = page.locator('[data-testid^="template-workflow-"]')
|
|
}
|
|
|
|
async expectMinimumCardCount(count: number) {
|
|
await expect
|
|
.poll(() => this.allTemplateCards.count())
|
|
.toBeGreaterThanOrEqual(count)
|
|
}
|
|
|
|
async loadTemplate(id: string) {
|
|
const templateCard = this.content.getByTestId(
|
|
TestIds.templates.workflowCard(id)
|
|
)
|
|
await templateCard.scrollIntoViewIfNeeded()
|
|
await templateCard.getByRole('img').click()
|
|
}
|
|
|
|
async getAllTemplates(): Promise<TemplateInfo[]> {
|
|
const templates: WorkflowTemplates[] = await this.page.evaluate(() =>
|
|
window.app!.api.getCoreWorkflowTemplates()
|
|
)
|
|
return templates.flatMap((t) => t.templates)
|
|
}
|
|
|
|
getTemplatePath(filename: string): string {
|
|
return path.join('public', 'templates', filename)
|
|
}
|
|
}
|