mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 08:20:53 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
79 lines
2.8 KiB
TypeScript
79 lines
2.8 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
import type { NodeReference } from '@e2e/fixtures/utils/litegraphUtils'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Primitive Node', { tag: ['@screenshot', '@node'] }, () => {
|
|
test('Can load with correct size', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('primitive/primitive_node')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('primitive_node.png')
|
|
})
|
|
|
|
// When link is dropped on widget, it should automatically convert the widget
|
|
// to input.
|
|
test('Can connect to widget', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'primitive/primitive_node_unconnected'
|
|
)
|
|
const primitiveNode: NodeReference =
|
|
await comfyPage.nodeOps.getNodeRefById(1)
|
|
const ksamplerNode: NodeReference =
|
|
await comfyPage.nodeOps.getNodeRefById(2)
|
|
// Connect the output of the primitive node to the input of first widget of the ksampler node
|
|
await primitiveNode.connectWidget(0, ksamplerNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'primitive_node_connected.png'
|
|
)
|
|
})
|
|
|
|
test('Can connect to dom widget', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'primitive/primitive_node_unconnected_dom_widget'
|
|
)
|
|
const primitiveNode: NodeReference =
|
|
await comfyPage.nodeOps.getNodeRefById(1)
|
|
const clipEncoderNode: NodeReference =
|
|
await comfyPage.nodeOps.getNodeRefById(2)
|
|
await primitiveNode.connectWidget(0, clipEncoderNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'primitive_node_connected_dom_widget.png'
|
|
)
|
|
})
|
|
|
|
test('Can connect to static primitive node', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'primitive/static_primitive_unconnected'
|
|
)
|
|
const primitiveNode: NodeReference =
|
|
await comfyPage.nodeOps.getNodeRefById(1)
|
|
const ksamplerNode: NodeReference =
|
|
await comfyPage.nodeOps.getNodeRefById(2)
|
|
await primitiveNode.connectWidget(0, ksamplerNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'static_primitive_connected.png'
|
|
)
|
|
})
|
|
|
|
test('Report missing nodes when connect to missing node', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.RightSidePanel.ShowErrorsTab',
|
|
true
|
|
)
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'primitive/primitive_node_connect_missing_node'
|
|
)
|
|
const errorOverlay = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.errorOverlay
|
|
)
|
|
await expect(errorOverlay).toBeVisible()
|
|
})
|
|
})
|