mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 08:20:53 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
74 lines
2.4 KiB
TypeScript
74 lines
2.4 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
import { PropertiesPanelHelper } from '@e2e/tests/propertiesPanel/PropertiesPanelHelper'
|
|
|
|
test.describe('Errors tab - common', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.RightSidePanel.ShowErrorsTab',
|
|
true
|
|
)
|
|
})
|
|
|
|
test.describe('Tab visibility', () => {
|
|
test('Should show Errors tab when errors exist', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('missing/missing_nodes')
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
await comfyPage.nextFrame()
|
|
|
|
const panel = new PropertiesPanelHelper(comfyPage.page)
|
|
await expect(panel.errorsTabIcon).toBeVisible()
|
|
})
|
|
|
|
test('Should not show Errors tab when setting is disabled', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.workflow.loadWorkflow('missing/missing_nodes')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.RightSidePanel.ShowErrorsTab',
|
|
false
|
|
)
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
await comfyPage.nextFrame()
|
|
|
|
const panel = new PropertiesPanelHelper(comfyPage.page)
|
|
await expect(panel.errorsTabIcon).not.toBeVisible()
|
|
})
|
|
})
|
|
|
|
test.describe('Search and filter', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
test('Should filter execution errors by search query', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.workflow.loadWorkflow('nodes/execution_error')
|
|
await comfyPage.command.executeCommand('Comfy.QueuePrompt')
|
|
await comfyPage.nextFrame()
|
|
|
|
const errorOverlay = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.errorOverlay
|
|
)
|
|
await expect(errorOverlay).toBeVisible()
|
|
await errorOverlay
|
|
.getByTestId(TestIds.dialogs.errorOverlaySeeErrors)
|
|
.click()
|
|
|
|
const runtimePanel = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.runtimeErrorPanel
|
|
)
|
|
await expect(runtimePanel).toBeVisible()
|
|
|
|
const searchInput = comfyPage.page.getByPlaceholder(/^Search/)
|
|
await searchInput.fill('nonexistent_query_xyz_12345')
|
|
|
|
await expect(runtimePanel).not.toBeVisible()
|
|
})
|
|
})
|
|
})
|