mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 08:20:53 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
95 lines
3.1 KiB
TypeScript
95 lines
3.1 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
test.describe('Properties panel position', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.NodeLibrary.NewDesign', false)
|
|
// Open a sidebar tab to ensure sidebar is visible
|
|
await comfyPage.menu.nodeLibraryTab.open()
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
})
|
|
|
|
test('positions on the right when sidebar is on the left', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'left')
|
|
await comfyPage.nextFrame()
|
|
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
const sidebar = comfyPage.page.locator('.side-bar-panel').first()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
await expect(sidebar).toBeVisible()
|
|
|
|
const propsBoundingBox = await propertiesPanel.boundingBox()
|
|
const sidebarBoundingBox = await sidebar.boundingBox()
|
|
|
|
expect(propsBoundingBox).not.toBeNull()
|
|
expect(sidebarBoundingBox).not.toBeNull()
|
|
|
|
// Properties panel should be to the right of the sidebar
|
|
expect(propsBoundingBox!.x).toBeGreaterThan(
|
|
sidebarBoundingBox!.x + sidebarBoundingBox!.width
|
|
)
|
|
})
|
|
|
|
test('positions on the left when sidebar is on the right', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'right')
|
|
await comfyPage.nextFrame()
|
|
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
const sidebar = comfyPage.page.locator('.side-bar-panel').first()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
await expect(sidebar).toBeVisible()
|
|
|
|
const propsBoundingBox = await propertiesPanel.boundingBox()
|
|
const sidebarBoundingBox = await sidebar.boundingBox()
|
|
|
|
expect(propsBoundingBox).not.toBeNull()
|
|
expect(sidebarBoundingBox).not.toBeNull()
|
|
|
|
// Properties panel should be to the left of the sidebar
|
|
expect(propsBoundingBox!.x + propsBoundingBox!.width).toBeLessThan(
|
|
sidebarBoundingBox!.x
|
|
)
|
|
})
|
|
|
|
test('close button icon updates based on sidebar location', async ({
|
|
comfyPage
|
|
}) => {
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
|
|
// When sidebar is on the left, panel is on the right
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'left')
|
|
await comfyPage.nextFrame()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
const closeButtonLeft = propertiesPanel
|
|
.locator('button[aria-pressed]')
|
|
.locator('i')
|
|
await expect(closeButtonLeft).toBeVisible()
|
|
await expect(closeButtonLeft).toHaveClass(/lucide--panel-right/)
|
|
|
|
// When sidebar is on the right, panel is on the left
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'right')
|
|
await comfyPage.nextFrame()
|
|
|
|
const closeButtonRight = propertiesPanel
|
|
.locator('button[aria-pressed]')
|
|
.locator('i')
|
|
await expect(closeButtonRight).toBeVisible()
|
|
await expect(closeButtonRight).toHaveClass(/lucide--panel-left/)
|
|
})
|
|
})
|