mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 08:20:53 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
57 lines
1.9 KiB
TypeScript
57 lines
1.9 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import type { ComfyWorkflowJSON } from '@/platform/workflow/validation/schemas/workflowSchema'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
/**
|
|
* Tests that templates are automatically fitted to view when loaded.
|
|
*
|
|
* When openSource === 'template', fitView() is called to ensure
|
|
* templates with saved off-screen viewport positions (extra.ds)
|
|
* are always displayed correctly.
|
|
*/
|
|
test.describe('Template Fit View', { tag: ['@canvas', '@workflow'] }, () => {
|
|
test('should automatically fit view when loading a template with off-screen saved position', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.EnableWorkflowViewRestore', true)
|
|
|
|
// Serialize the current default graph, inject an extreme off-screen
|
|
// viewport position, then reload it as a template. Without the fix,
|
|
// the saved offset [-5000, -5000] would be restored and nodes would
|
|
// be invisible.
|
|
const viewportState = await comfyPage.page.evaluate(async () => {
|
|
const app = window.app!
|
|
const workflow = app.graph.serialize()
|
|
|
|
workflow.extra = {
|
|
...workflow.extra,
|
|
ds: { scale: 1, offset: [-5000, -5000] }
|
|
}
|
|
|
|
await app.loadGraphData(workflow as ComfyWorkflowJSON, true, true, null, {
|
|
openSource: 'template'
|
|
})
|
|
|
|
return {
|
|
offsetX: app.canvas.ds.offset[0],
|
|
offsetY: app.canvas.ds.offset[1],
|
|
nodeCount: app.graph._nodes.length
|
|
}
|
|
})
|
|
|
|
expect(viewportState.nodeCount).toBeGreaterThan(0)
|
|
|
|
// fitView() should have overridden the saved [-5000, -5000] offset
|
|
expect(
|
|
viewportState.offsetX,
|
|
'Viewport X offset should not be the saved off-screen value'
|
|
).not.toBe(-5000)
|
|
expect(
|
|
viewportState.offsetY,
|
|
'Viewport Y offset should not be the saved off-screen value'
|
|
).not.toBe(-5000)
|
|
})
|
|
})
|