mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 08:20:53 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
74 lines
2.1 KiB
TypeScript
74 lines
2.1 KiB
TypeScript
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Toast Notifications', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
async function triggerErrorToast(comfyPage: {
|
|
page: { evaluate: (fn: () => void) => Promise<void> }
|
|
nextFrame: () => Promise<void>
|
|
}) {
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.extensionManager.toast.add({
|
|
severity: 'error',
|
|
summary: 'Error',
|
|
detail: 'Test execution error',
|
|
life: 30000
|
|
})
|
|
})
|
|
await comfyPage.nextFrame()
|
|
}
|
|
|
|
test('Error toast appears when triggered', async ({ comfyPage }) => {
|
|
await triggerErrorToast(comfyPage)
|
|
|
|
await expect(comfyPage.toast.visibleToasts.first()).toBeVisible()
|
|
})
|
|
|
|
test('Toast shows correct error severity class', async ({ comfyPage }) => {
|
|
await triggerErrorToast(comfyPage)
|
|
|
|
const errorToast = comfyPage.page.locator(
|
|
'.p-toast-message.p-toast-message-error'
|
|
)
|
|
await expect(errorToast.first()).toBeVisible()
|
|
})
|
|
|
|
test('Toast can be dismissed via close button', async ({ comfyPage }) => {
|
|
await triggerErrorToast(comfyPage)
|
|
|
|
await expect(comfyPage.toast.visibleToasts.first()).toBeVisible()
|
|
|
|
const closeButton = comfyPage.page.locator('.p-toast-close-button').first()
|
|
await closeButton.click()
|
|
|
|
await expect(comfyPage.toast.visibleToasts).toHaveCount(0)
|
|
})
|
|
|
|
test('All toasts cleared via closeToasts helper', async ({ comfyPage }) => {
|
|
await triggerErrorToast(comfyPage)
|
|
|
|
await expect(comfyPage.toast.visibleToasts.first()).toBeVisible()
|
|
|
|
await comfyPage.toast.closeToasts()
|
|
|
|
expect(await comfyPage.toast.getVisibleToastCount()).toBe(0)
|
|
})
|
|
|
|
test('Toast error count is accurate', async ({ comfyPage }) => {
|
|
await triggerErrorToast(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('.p-toast-message.p-toast-message-error').first()
|
|
).toBeVisible()
|
|
|
|
const errorCount = await comfyPage.toast.getToastErrorCount()
|
|
expect(errorCount).toBeGreaterThanOrEqual(1)
|
|
})
|
|
})
|