mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-21 14:59:39 +00:00

Files

bymyself 380f335bff feat: Integrate ComfyUI Manager migration with v2 API and enhanced UI

This commit integrates the previously recovered ComfyUI Manager functionality
with significant enhancements from PR #3367, including:

## Core Manager System Recovery
- **v2 API Integration**: All manager endpoints now use `/v2/manager/queue/*`
- **Task Queue System**: Complete client-side task queuing with WebSocket status
- **Service Layer**: Comprehensive manager service with all CRUD operations
- **Store Integration**: Full manager store with progress dialog support

## New Features & Enhancements
- **Reactive Feature Flags**: Foundation for dynamic feature toggling
- **Enhanced UI Components**: Improved loading states, progress tracking
- **Package Management**: Install, update, enable/disable functionality
- **Version Selection**: Support for latest/nightly package versions
- **Progress Dialogs**: Real-time installation progress with logs
- **Missing Node Detection**: Automated detection and installation prompts

## Technical Improvements
- **TypeScript Definitions**: Complete type system for manager operations
- **WebSocket Integration**: Real-time status updates via `cm-queue-status`
- **Error Handling**: Comprehensive error handling with user feedback
- **Testing**: Updated test suites for new functionality
- **Documentation**: Complete backup documentation for recovery process

## API Endpoints Restored
- `manager/queue/start` - Start task queue
- `manager/queue/status` - Get queue status
- `manager/queue/task` - Queue individual tasks
- `manager/queue/install` - Install packages
- `manager/queue/update` - Update packages
- `manager/queue/disable` - Disable packages

## Breaking Changes
- Manager API base URL changed to `/v2/`
- Updated TypeScript interfaces for manager operations
- New WebSocket message format for queue status

This restores all critical manager functionality lost during the previous
rebase while integrating the latest enhancements and maintaining compatibility
with the current main branch.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-08-30 13:44:27 -07:00

2.9 KiB

Raw Blame History

ComfyUI Frontend Project Guidelines

Repository Setup

For first-time setup, use the Claude command:

/setup_repo

This bootstraps the monorepo with dependencies, builds, tests, and dev server verification.

Prerequisites: Node.js >= 24, Git repository, available ports (5173, 6006)

Quick Commands

pnpm: See all available commands
pnpm dev: Start development server (port 5173, via nx)
pnpm typecheck: Type checking
pnpm build: Build for production (via nx)
pnpm lint: Linting (via nx)
pnpm format: Prettier formatting
pnpm test:component: Run component tests with browser environment
pnpm test:unit: Run all unit tests
pnpm test:browser: Run E2E tests via Playwright
pnpm test:unit -- tests-ui/tests/example.test.ts: Run single test file
pnpm storybook: Start Storybook development server (port 6006)
pnpm knip: Detect unused code and dependencies

Monorepo Architecture

The project now uses Nx for build orchestration and task management:

Task Orchestration: Commands like dev, build, lint, and test:browser run via Nx
Caching: Nx provides intelligent caching for faster rebuilds
Configuration: Managed through nx.json with plugins for ESLint, Storybook, Vite, and Playwright
Dependencies: Nx handles dependency graph analysis and parallel execution

Key Nx features:

Build target caching and incremental builds
Parallel task execution across the monorepo
Plugin-based architecture for different tools

Development Workflow

First-time setup: Run /setup_repo Claude command
Make code changes
Run tests (see subdirectory CLAUDE.md files)
Run typecheck, lint, format
Check README updates
Consider docs.comfy.org updates

Git Conventions

Use [prefix] format: [feat], [bugfix], [docs]
Add "Fixes #n" to PR descriptions
Never mention Claude/AI in commits

External Resources

PrimeVue docs: https://primevue.org
ComfyUI docs: https://docs.comfy.org
Electron: https://www.electronjs.org/docs/latest/
Wiki: https://deepwiki.com/Comfy-Org/ComfyUI_frontend/1-overview

Project Philosophy

Clean, stable public APIs
Domain-driven design
Thousands of users and extensions
Prioritize clean interfaces that restrict extension access

Check README files in key folders (tests-ui, browser_tests, composables, etc.)
Prefer running single tests for performance
Use --help for unfamiliar CLI tools

GitHub Integration

When referencing Comfy-Org repos:

Check for local copy
Use GitHub API for branches/PRs/metadata
Curl GitHub website if needed

Common Pitfalls

NEVER use any type - use proper TypeScript types
NEVER use as any type assertions - fix the underlying type issue
NEVER use --no-verify flag when committing
NEVER delete or disable tests to make them pass
NEVER circumvent quality checks

2.9 KiB Raw Blame History