mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-05 05:32:02 +00:00
8e233d07b0
## Summary
This PR removes unsafe type assertions ("as unknown as Type") from test
files and improves type safety across the codebase.
### Key Changes
#### Type Safety Improvements
- Removed all instances of "as unknown as" patterns from test files
- Used proper factory functions from litegraphTestUtils instead of
custom mocks
- Made incomplete mocks explicit using Partial<T> types
- Fixed DialogStore mocking with proper interface exports
- Improved type safety with satisfies operator where applicable
#### App Parameter Removal
- **Removed the unused `app` parameter from all ComfyExtension interface
methods**
- The app parameter was always undefined at runtime as it was never
passed from invokeExtensions
- Affected methods: init, setup, addCustomNodeDefs,
beforeRegisterNodeDef, beforeRegisterVueAppNodeDefs,
registerCustomNodes, loadedGraphNode, nodeCreated, beforeConfigureGraph,
afterConfigureGraph
##### Breaking Change Analysis
Verified via Sourcegraph that this is NOT a breaking change:
- Searched all 10 affected methods across GitHub repositories
- Only one external repository
([drawthingsai/draw-things-comfyui](https://github.com/drawthingsai/draw-things-comfyui))
declares the app parameter in their extension methods
- That repository never actually uses the app parameter (just declares
it in the function signature)
- All other repositories already omit the app parameter
- Search queries used:
- [init method
search](https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/.*+lang:typescript+%22init%28app%22+-repo:Comfy-Org/ComfyUI_frontend&patternType=standard)
- [setup method
search](https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/.*+lang:typescript+%22setup%28app%22+-repo:Comfy-Org/ComfyUI_frontend&patternType=standard)
- Similar searches for all 10 methods confirmed no usage
### Files Changed
Test files:
-
src/components/settings/widgets/__tests__/WidgetInputNumberInput.test.ts
- src/services/keybindingService.escape.test.ts
- src/services/keybindingService.forwarding.test.ts
- src/utils/__tests__/newUserService.test.ts →
src/utils/__tests__/useNewUserService.test.ts
- src/services/jobOutputCache.test.ts
-
src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts
-
src/renderer/extensions/vueNodes/widgets/composables/useIntWidget.test.ts
-
src/renderer/extensions/vueNodes/widgets/composables/useFloatWidget.test.ts
Source files:
- src/types/comfy.ts - Removed app parameter from ComfyExtension
interface
- src/services/extensionService.ts - Improved type safety with
FunctionPropertyNames helper
- src/scripts/metadata/isobmff.ts - Fixed extractJson return type per
review
- src/extensions/core/*.ts - Updated extension implementations
- src/scripts/app.ts - Updated app initialization
### Testing
- All existing tests pass
- Type checking passes
- ESLint/oxlint checks pass
- No breaking changes for external repositories
Part of the "Road to No Explicit Any" initiative.
### Previous PRs in this series:
- Part 2: #7401
- Part 3: #7935
- Part 4: #7970
- Part 5: #8064
- Part 6: #8083
- Part 7: #8092
- Part 8 Group 1: #8253
- Part 8 Group 2: #8258
- Part 8 Group 3: #8304
- Part 8 Group 4: #8314
- Part 8 Group 5: #8329
- Part 8 Group 6: #8344 (this PR)
77 lines
2.0 KiB
TypeScript
77 lines
2.0 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import type { INumericWidget } from '@/lib/litegraph/src/types/widgets'
|
|
import { _for_testing } from '@/renderer/extensions/vueNodes/widgets/composables/useIntWidget'
|
|
|
|
vi.mock('@/scripts/widgets', () => ({
|
|
addValueControlWidgets: vi.fn()
|
|
}))
|
|
|
|
vi.mock('@/platform/settings/settingStore', () => ({
|
|
useSettingStore: () => ({
|
|
settings: {}
|
|
})
|
|
}))
|
|
|
|
const { onValueChange } = _for_testing
|
|
|
|
describe('useIntWidget', () => {
|
|
describe('onValueChange', () => {
|
|
let widget: INumericWidget
|
|
|
|
beforeEach(() => {
|
|
// Reset the widget before each test
|
|
widget = {
|
|
type: 'number',
|
|
name: 'test_widget',
|
|
y: 0,
|
|
options: {},
|
|
value: 0
|
|
} as Partial<INumericWidget> as INumericWidget
|
|
})
|
|
|
|
it('should round values based on step size', () => {
|
|
widget.options.step2 = 0.1
|
|
onValueChange.call(widget, 5.7)
|
|
expect(widget.value).toBe(5.7)
|
|
|
|
widget.options.step2 = 0.5
|
|
onValueChange.call(widget, 7.3)
|
|
expect(widget.value).toBe(7.5)
|
|
|
|
widget.options.step2 = 1
|
|
onValueChange.call(widget, 23.4)
|
|
expect(widget.value).toBe(23)
|
|
})
|
|
|
|
it('should handle undefined step by using default of 1', () => {
|
|
widget.options.step2 = undefined
|
|
onValueChange.call(widget, 3.7)
|
|
expect(widget.value).toBe(4)
|
|
})
|
|
|
|
it('should account for min value offset', () => {
|
|
widget.options.step2 = 2
|
|
widget.options.min = 1
|
|
// 2 valid values between 1.6 are 1 and 3
|
|
// 1.6 is closer to 1, so it should round to 1
|
|
onValueChange.call(widget, 1.6)
|
|
expect(widget.value).toBe(1)
|
|
})
|
|
|
|
it('should handle undefined min by using default of 0', () => {
|
|
widget.options.step2 = 2
|
|
widget.options.min = undefined
|
|
onValueChange.call(widget, 5.7)
|
|
expect(widget.value).toBe(6)
|
|
})
|
|
|
|
it('should handle NaN shift value', () => {
|
|
widget.options.step2 = 0
|
|
widget.options.min = 1
|
|
onValueChange.call(widget, 5.7)
|
|
expect(widget.value).toBe(6)
|
|
})
|
|
})
|
|
})
|