mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-31 13:29:55 +00:00
* refactor: move settingStore to platform/settings Move src/stores/settingStore.ts to src/platform/settings/settingStore.ts to separate platform infrastructure from domain logic following DDD principles. Updates all import references across ~70 files to maintain compatibility. * fix: update remaining settingStore imports after rebase * fix: complete remaining settingStore import updates * fix: update vi.mock paths for settingStore in tests Update all test files to mock the new settingStore location at @/platform/settings/settingStore instead of @/stores/settingStore * fix: resolve remaining settingStore imports and unused imports after rebase * fix: update settingStore mock path in SelectionToolbox test Fix vi.mock path from @/stores/settingStore to @/platform/settings/settingStore to resolve failing Load3D viewer button test. * refactor: complete comprehensive settings migration to platform layer This commit completes the migration of all settings-related code to the platform layer as part of the Domain-Driven Design (DDD) architecture refactoring. - constants/coreSettings.ts → platform/settings/constants/coreSettings.ts - types/settingTypes.ts → platform/settings/types.ts - stores/settingStore.ts → platform/settings/settingStore.ts (already moved) - composables/setting/useSettingUI.ts → platform/settings/composables/useSettingUI.ts - composables/setting/useSettingSearch.ts → platform/settings/composables/useSettingSearch.ts - composables/useLitegraphSettings.ts → platform/settings/composables/useLitegraphSettings.ts - components/dialog/content/SettingDialogContent.vue → platform/settings/components/SettingDialogContent.vue - components/dialog/content/setting/SettingItem.vue → platform/settings/components/SettingItem.vue - components/dialog/content/setting/SettingGroup.vue → platform/settings/components/SettingGroup.vue - components/dialog/content/setting/SettingsPanel.vue → platform/settings/components/SettingsPanel.vue - components/dialog/content/setting/ColorPaletteMessage.vue → platform/settings/components/ColorPaletteMessage.vue - components/dialog/content/setting/ExtensionPanel.vue → platform/settings/components/ExtensionPanel.vue - components/dialog/content/setting/ServerConfigPanel.vue → platform/settings/components/ServerConfigPanel.vue - ~100+ import statements updated across the codebase - Test file imports corrected - Component imports fixed in dialog service and command menubar - Composable imports updated in GraphCanvas.vue ``` src/platform/settings/ ├── components/ # All settings UI components ├── composables/ # Settings-related composables ├── constants/ # Core settings definitions ├── types.ts # Settings type definitions └── settingStore.ts # Central settings state management ``` ✅ TypeScript compilation successful ✅ All tests passing (settings store, search functionality, UI components) ✅ Production build successful ✅ Domain boundaries properly established This migration consolidates all settings functionality into a cohesive platform domain, improving maintainability and following DDD principles for better code organization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: format and lint after rebase conflict resolution * fix: update remaining import paths to platform settings - Fix browser test import: extensionAPI.spec.ts - Fix script import: collect-i18n-general.ts - Complete settings migration import path updates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
75 lines
1.8 KiB
TypeScript
75 lines
1.8 KiB
TypeScript
import type { useSettingStore } from '@/platform/settings/settingStore'
|
|
|
|
let pendingCallbacks: Array<() => Promise<void>> = []
|
|
let isNewUserDetermined = false
|
|
let isNewUserCached: boolean | null = null
|
|
|
|
export const newUserService = () => {
|
|
function checkIsNewUser(
|
|
settingStore: ReturnType<typeof useSettingStore>
|
|
): boolean {
|
|
const isNewUserSettings =
|
|
Object.keys(settingStore.settingValues).length === 0 ||
|
|
!settingStore.get('Comfy.TutorialCompleted')
|
|
const hasNoWorkflow = !localStorage.getItem('workflow')
|
|
const hasNoPreviousWorkflow = !localStorage.getItem(
|
|
'Comfy.PreviousWorkflow'
|
|
)
|
|
|
|
return isNewUserSettings && hasNoWorkflow && hasNoPreviousWorkflow
|
|
}
|
|
|
|
async function registerInitCallback(callback: () => Promise<void>) {
|
|
if (isNewUserDetermined) {
|
|
if (isNewUserCached) {
|
|
try {
|
|
await callback()
|
|
} catch (error) {
|
|
console.error('New user initialization callback failed:', error)
|
|
}
|
|
}
|
|
} else {
|
|
pendingCallbacks.push(callback)
|
|
}
|
|
}
|
|
|
|
async function initializeIfNewUser(
|
|
settingStore: ReturnType<typeof useSettingStore>
|
|
) {
|
|
if (isNewUserDetermined) return
|
|
|
|
isNewUserCached = checkIsNewUser(settingStore)
|
|
isNewUserDetermined = true
|
|
|
|
if (!isNewUserCached) {
|
|
pendingCallbacks = []
|
|
return
|
|
}
|
|
|
|
await settingStore.set(
|
|
'Comfy.InstalledVersion',
|
|
__COMFYUI_FRONTEND_VERSION__
|
|
)
|
|
|
|
for (const callback of pendingCallbacks) {
|
|
try {
|
|
await callback()
|
|
} catch (error) {
|
|
console.error('New user initialization callback failed:', error)
|
|
}
|
|
}
|
|
|
|
pendingCallbacks = []
|
|
}
|
|
|
|
function isNewUser(): boolean | null {
|
|
return isNewUserDetermined ? isNewUserCached : null
|
|
}
|
|
|
|
return {
|
|
registerInitCallback,
|
|
initializeIfNewUser,
|
|
isNewUser
|
|
}
|
|
}
|