mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 23:20:07 +00:00
## Summary Improves type safety in test files by replacing unsafe type patterns with proper TypeScript idioms. ## Changes - Define typed `TestWindow` interface extending `Window` for Playwright tests with custom properties - Use `Partial<HTMLElement>` with single type assertion for DOM element mocks - Remove redundant type imports - Fix `console.log` → `console.warn` in test fixture ## Files Changed 16 test files across browser_tests, packages, and src/components ## Test Plan - ✅ `pnpm typecheck` passes - ✅ No new `any` types introduced - ✅ All pre-commit hooks pass ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8253-refactor-improve-TypeScript-patterns-in-test-files-Group-1-8-2f16d73d365081548f9ece7bcf0525ee) by [Unito](https://www.unito.io) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
220 lines
6.0 KiB
TypeScript
220 lines
6.0 KiB
TypeScript
import { mount } from '@vue/test-utils'
|
|
import PrimeVue from 'primevue/config'
|
|
import IconField from 'primevue/iconfield'
|
|
import InputIcon from 'primevue/inputicon'
|
|
import InputText from 'primevue/inputtext'
|
|
import { beforeEach, describe, expect, it } from 'vitest'
|
|
import { createApp, nextTick } from 'vue'
|
|
|
|
import UrlInput from './UrlInput.vue'
|
|
import type { ComponentProps } from 'vue-component-type-helpers'
|
|
|
|
describe('UrlInput', () => {
|
|
beforeEach(() => {
|
|
const app = createApp({})
|
|
app.use(PrimeVue)
|
|
})
|
|
|
|
const mountComponent = (
|
|
props: ComponentProps<typeof UrlInput> & {
|
|
placeholder?: string
|
|
disabled?: boolean
|
|
},
|
|
options = {}
|
|
) => {
|
|
return mount(UrlInput, {
|
|
global: {
|
|
plugins: [PrimeVue],
|
|
components: { IconField, InputIcon, InputText }
|
|
},
|
|
props,
|
|
...options
|
|
})
|
|
}
|
|
|
|
it('passes through additional attributes to input element', () => {
|
|
const wrapper = mountComponent({
|
|
modelValue: '',
|
|
placeholder: 'Enter URL',
|
|
disabled: true
|
|
})
|
|
|
|
expect(wrapper.find('input').attributes('disabled')).toBe('')
|
|
})
|
|
|
|
it('emits update:modelValue on blur', async () => {
|
|
const wrapper = mountComponent({
|
|
modelValue: '',
|
|
placeholder: 'Enter URL'
|
|
})
|
|
|
|
const input = wrapper.find('input')
|
|
await input.setValue('https://test.com/')
|
|
await input.trigger('blur')
|
|
|
|
expect(wrapper.emitted('update:modelValue')?.[0]).toEqual([
|
|
'https://test.com/'
|
|
])
|
|
})
|
|
|
|
it('renders spinner when validation is loading', async () => {
|
|
const wrapper = mountComponent({
|
|
modelValue: '',
|
|
placeholder: 'Enter URL',
|
|
validateUrlFn: () =>
|
|
new Promise(() => {
|
|
// Never resolves, simulating perpetual loading state
|
|
})
|
|
})
|
|
|
|
await wrapper.setProps({ modelValue: 'https://test.com' })
|
|
await nextTick()
|
|
await nextTick()
|
|
|
|
expect(wrapper.find('.pi-spinner').exists()).toBe(true)
|
|
})
|
|
|
|
it('renders check icon when validation is valid', async () => {
|
|
const wrapper = mountComponent({
|
|
modelValue: '',
|
|
placeholder: 'Enter URL',
|
|
validateUrlFn: () => Promise.resolve(true)
|
|
})
|
|
|
|
await wrapper.setProps({ modelValue: 'https://test.com' })
|
|
await nextTick()
|
|
await nextTick()
|
|
|
|
expect(wrapper.find('.pi-check').exists()).toBe(true)
|
|
})
|
|
|
|
it('renders cross icon when validation is invalid', async () => {
|
|
const wrapper = mountComponent({
|
|
modelValue: '',
|
|
placeholder: 'Enter URL',
|
|
validateUrlFn: () => Promise.resolve(false)
|
|
})
|
|
|
|
await wrapper.setProps({ modelValue: 'https://test.com' })
|
|
await nextTick()
|
|
await nextTick()
|
|
|
|
expect(wrapper.find('.pi-times').exists()).toBe(true)
|
|
})
|
|
|
|
it('validates on mount', async () => {
|
|
const wrapper = mountComponent({
|
|
modelValue: 'https://test.com',
|
|
validateUrlFn: () => Promise.resolve(true)
|
|
})
|
|
|
|
await nextTick()
|
|
await nextTick()
|
|
|
|
expect(wrapper.find('.pi-check').exists()).toBe(true)
|
|
})
|
|
|
|
it('triggers validation when clicking the validation icon', async () => {
|
|
let validationCount = 0
|
|
const wrapper = mountComponent({
|
|
modelValue: 'https://test.com',
|
|
validateUrlFn: () => {
|
|
validationCount++
|
|
return Promise.resolve(true)
|
|
}
|
|
})
|
|
|
|
// Wait for initial validation
|
|
await nextTick()
|
|
await nextTick()
|
|
|
|
// Click the validation icon
|
|
await wrapper.find('.pi-check').trigger('click')
|
|
await nextTick()
|
|
await nextTick()
|
|
|
|
expect(validationCount).toBe(2) // Once on mount, once on click
|
|
})
|
|
|
|
it('prevents multiple simultaneous validations', async () => {
|
|
let validationCount = 0
|
|
const wrapper = mountComponent({
|
|
modelValue: '',
|
|
validateUrlFn: () => {
|
|
validationCount++
|
|
return new Promise(() => {
|
|
// Never resolves, simulating perpetual loading state
|
|
})
|
|
}
|
|
})
|
|
|
|
await wrapper.setProps({ modelValue: 'https://test.com' })
|
|
await nextTick()
|
|
await nextTick()
|
|
|
|
// Trigger multiple validations in quick succession
|
|
await wrapper.find('.pi-spinner').trigger('click')
|
|
await wrapper.find('.pi-spinner').trigger('click')
|
|
await wrapper.find('.pi-spinner').trigger('click')
|
|
|
|
await nextTick()
|
|
await nextTick()
|
|
|
|
expect(validationCount).toBe(1) // Only the initial validation should occur
|
|
})
|
|
|
|
describe('input cleaning functionality', () => {
|
|
it('trims whitespace when user types', async () => {
|
|
const wrapper = mountComponent({
|
|
modelValue: '',
|
|
placeholder: 'Enter URL'
|
|
})
|
|
|
|
const input = wrapper.find('input')
|
|
|
|
// Test leading whitespace
|
|
await input.setValue(' https://leading-space.com')
|
|
await input.trigger('input')
|
|
await nextTick()
|
|
expect(input.element.value).toBe('https://leading-space.com')
|
|
|
|
// Test trailing whitespace
|
|
await input.setValue('https://trailing-space.com ')
|
|
await input.trigger('input')
|
|
await nextTick()
|
|
expect(input.element.value).toBe('https://trailing-space.com')
|
|
|
|
// Test both leading and trailing whitespace
|
|
await input.setValue(' https://both-spaces.com ')
|
|
await input.trigger('input')
|
|
await nextTick()
|
|
expect(input.element.value).toBe('https://both-spaces.com')
|
|
|
|
// Test whitespace in the middle of the URL
|
|
await input.setValue('https:// middle-space.com')
|
|
await input.trigger('input')
|
|
await nextTick()
|
|
expect(input.element.value).toBe('https://middle-space.com')
|
|
})
|
|
|
|
it('trims whitespace when value set externally', async () => {
|
|
const wrapper = mountComponent({
|
|
modelValue: ' https://initial-value.com ',
|
|
placeholder: 'Enter URL'
|
|
})
|
|
|
|
const input = wrapper.find('input')
|
|
|
|
// Check initial value is trimmed
|
|
expect(input.element.value).toBe('https://initial-value.com')
|
|
|
|
// Update props with whitespace
|
|
await wrapper.setProps({ modelValue: ' https://updated-value.com ' })
|
|
await nextTick()
|
|
|
|
// Check updated value is trimmed
|
|
expect(input.element.value).toBe('https://updated-value.com')
|
|
})
|
|
})
|
|
})
|