mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-22 21:38:52 +00:00
8abfa678a3
## Problem The GH Pages coverage deploy has been failing since #11291 merged — every `CI: E2E Coverage` workflow run errors out and https://comfy-org.github.io/ComfyUI_frontend/ returns 404. Additionally, two correctness/security issues were identified in the workflow (filed as #11374 and #11375). ## Changes 1. **`--ignore-errors source` on genhtml** — merged LCOV data includes paths like `localhost-8188/assets/main-BRkC1B8m.js` from Playwright V8 coverage instrumented runtime bundles that don't exist as source files in CI, causing genhtml to error out 2. **Pin checkout to `workflow_run.head_sha`** — in `workflow_run` context, the default checkout ref points to the default branch, not the commit that triggered the upstream run; genhtml could annotate against wrong source files (#11375) 3. **Gate deploy on `event == 'push'`** — a fork branch named `main` could satisfy the branch check and overwrite production coverage; adding the event guard prevents this (#11375) 4. **Include workflow run link in placeholder HTML** — when no coverage data is available, the placeholder page now links back to the workflow run for debugging (#11374) ## Fixes - Fixes the GH Pages 404 caused by #11291 - Fixes #11374 - Fixes #11375
GitHub Workflows
Naming Convention
Workflow files follow a consistent naming pattern: <prefix>-<descriptive-name>.yaml
Category Prefixes
| Prefix | Purpose | Example |
|---|---|---|
ci- |
Testing, linting, validation | ci-tests-e2e.yaml |
release- |
Version management, publishing | release-version-bump.yaml |
pr- |
PR automation (triggered by labels) | pr-claude-review.yaml |
api- |
External Api type generation | api-update-registry-api-types.yaml |
i18n- |
Internationalization updates | i18n-update-core.yaml |
Documentation
Each workflow file contains comments explaining its purpose, triggers, and behavior. For specific details about what each workflow does, refer to the comments at the top of each .yaml file.
For GitHub Actions documentation, see Events that trigger workflows.