mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
60 lines
1.7 KiB
TypeScript
60 lines
1.7 KiB
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
|
|
import type { AutoQueueMode } from '@/stores/queueStore'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
import type { WorkspaceStore } from '@e2e/types/globals'
|
|
|
|
export class ComfyActionbar {
|
|
public readonly root: Locator
|
|
public readonly queueButton: ComfyQueueButton
|
|
public readonly propertiesButton: Locator
|
|
|
|
constructor(public readonly page: Page) {
|
|
this.root = page.locator('.actionbar-container')
|
|
this.queueButton = new ComfyQueueButton(this)
|
|
this.propertiesButton = this.root.getByLabel('Toggle properties panel')
|
|
}
|
|
|
|
async isDocked() {
|
|
const className = await this.root
|
|
.locator('.actionbar')
|
|
.getAttribute('class')
|
|
return className?.includes('static') ?? false
|
|
}
|
|
}
|
|
|
|
class ComfyQueueButton {
|
|
public readonly root: Locator
|
|
public readonly primaryButton: Locator
|
|
public readonly dropdownButton: Locator
|
|
constructor(public readonly actionbar: ComfyActionbar) {
|
|
this.root = actionbar.root.getByTestId(TestIds.topbar.queueButton)
|
|
this.primaryButton = this.root
|
|
this.dropdownButton = actionbar.root.getByTestId(
|
|
TestIds.topbar.queueModeMenuTrigger
|
|
)
|
|
}
|
|
|
|
public async toggleOptions() {
|
|
await this.dropdownButton.click()
|
|
return new ComfyQueueButtonOptions(this.actionbar.page)
|
|
}
|
|
}
|
|
|
|
class ComfyQueueButtonOptions {
|
|
constructor(public readonly page: Page) {}
|
|
|
|
public async setMode(mode: AutoQueueMode) {
|
|
await this.page.evaluate((mode) => {
|
|
;(window.app!.extensionManager as WorkspaceStore).queueSettings.mode =
|
|
mode
|
|
}, mode)
|
|
}
|
|
|
|
public async getMode() {
|
|
return await this.page.evaluate(() => {
|
|
return (window.app!.extensionManager as WorkspaceStore).queueSettings.mode
|
|
})
|
|
}
|
|
}
|