mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
eaf1f9ac77
## Summary Add 2 reusable test helpers for Playwright E2E tests, integrated into the ComfyPage fixture. These provide standardized patterns for mocking feature flags and queue state across all E2E tests. ## Changes - **`FeatureFlagHelper.ts`** — manage localStorage `ff:` prefixed feature flags (`seedFlags` for init-time, `setFlags` for runtime) and mock `/api/features` route - **`QueueHelper.ts`** — mock `/api/queue` and `/api/history` routes with configurable running/pending counts and success/error job entries - **`ComfyPage.ts`** — integrate both helpers as `comfyPage.featureFlags` and `comfyPage.queue` ## Review Focus - Helper API design: are `seedFlags`/`setFlags`/`mockServerFeatures` the right abstractions for feature flag testing? - Queue mock fidelity: does the mock history shape match real ComfyUI API responses closely enough? - These are test-only infrastructure — no production code changes. ## Stack This is the base PR for the Playwright E2E coverage stack. Waves 1-4 all branch from this and can merge independently once this lands: - **→ This PR**: Test infrastructure helpers - #9555: Toasts, error overlay, selection toolbox, linear mode, selection rectangle - #9556: Node search, bottom panel, focus mode, job history, side panel - #9557: Errors tab, node headers, queue notifications, settings sidebar - #9558: Minimap, widget copy, floating menus, node library essentials --------- Co-authored-by: GitHub Action <action@github.com>
101 lines
3.1 KiB
TypeScript
101 lines
3.1 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
import { TestIds } from '../fixtures/selectors'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Graph Canvas Menu', { tag: ['@screenshot', '@canvas'] }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
// Set link render mode to spline to make sure it's not affected by other tests'
|
|
// side effects.
|
|
await comfyPage.settings.setSetting('Comfy.LinkRenderMode', 2)
|
|
// Enable canvas menu for all tests
|
|
await comfyPage.settings.setSetting('Comfy.Graph.CanvasMenu', true)
|
|
})
|
|
|
|
test(
|
|
'Can toggle link visibility',
|
|
{ tag: '@screenshot' },
|
|
async ({ comfyPage }) => {
|
|
const button = comfyPage.page.getByTestId(
|
|
TestIds.canvas.toggleLinkVisibilityButton
|
|
)
|
|
await button.click()
|
|
await comfyPage.nextFrame()
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'canvas-with-hidden-links.png'
|
|
)
|
|
const hiddenLinkRenderMode = await comfyPage.page.evaluate(() => {
|
|
return window.LiteGraph!.HIDDEN_LINK
|
|
})
|
|
expect(await comfyPage.settings.getSetting('Comfy.LinkRenderMode')).toBe(
|
|
hiddenLinkRenderMode
|
|
)
|
|
|
|
await button.click()
|
|
await comfyPage.nextFrame()
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'canvas-with-visible-links.png'
|
|
)
|
|
expect(
|
|
await comfyPage.settings.getSetting('Comfy.LinkRenderMode')
|
|
).not.toBe(hiddenLinkRenderMode)
|
|
}
|
|
)
|
|
|
|
test('Toggle minimap button is clickable and has correct test id', async ({
|
|
comfyPage
|
|
}) => {
|
|
const minimapButton = comfyPage.page.getByTestId(
|
|
TestIds.canvas.toggleMinimapButton
|
|
)
|
|
await expect(minimapButton).toBeVisible()
|
|
await expect(minimapButton).toBeEnabled()
|
|
|
|
// Test that the button can be clicked without error
|
|
await minimapButton.click()
|
|
await comfyPage.nextFrame()
|
|
})
|
|
|
|
test('Fit view button is present and clickable', async ({ comfyPage }) => {
|
|
const fitViewButton = comfyPage.page
|
|
.locator('button')
|
|
.filter({ has: comfyPage.page.locator('.icon-\\[lucide--focus\\]') })
|
|
await expect(fitViewButton).toBeVisible()
|
|
await fitViewButton.click()
|
|
await comfyPage.nextFrame()
|
|
})
|
|
|
|
test('Zoom controls popup opens and closes', async ({ comfyPage }) => {
|
|
// Find the zoom button by its percentage text content
|
|
const zoomButton = comfyPage.page.locator('button').filter({
|
|
hasText: '%'
|
|
})
|
|
await expect(zoomButton).toBeVisible()
|
|
|
|
// Click to open zoom controls
|
|
await zoomButton.click()
|
|
await comfyPage.nextFrame()
|
|
|
|
// Zoom controls modal should be visible
|
|
const zoomModal = comfyPage.page
|
|
.locator('div')
|
|
.filter({
|
|
hasText: 'Zoom To Fit'
|
|
})
|
|
.first()
|
|
await expect(zoomModal).toBeVisible()
|
|
|
|
// Click backdrop to close
|
|
const backdrop = comfyPage.page.locator('.fixed.inset-0').first()
|
|
await backdrop.click()
|
|
await comfyPage.nextFrame()
|
|
|
|
// Modal should be hidden
|
|
await expect(zoomModal).not.toBeVisible()
|
|
})
|
|
})
|