mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-21 07:14:11 +00:00
a1c54ad7aa
Fixes #8882 Adds explicit type annotations to all extension callback parameters (`nodeCreated`, `beforeRegisterNodeDef`, `addCustomNodeDefs`) across 14 core extension files. While the types were already inferred from the `ComfyExtension` interface, explicit annotations improve readability and make the code self-documenting. ## Changes - Annotate `node` parameter as `LGraphNode` in all `nodeCreated` callbacks - Annotate `nodeType` as `typeof LGraphNode` and `nodeData` as `ComfyNodeDef` in all `beforeRegisterNodeDef` callbacks - Annotate `defs` as `Record<string, ComfyNodeDef>` in `addCustomNodeDefs` - Add necessary type imports where missing ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8966-fix-add-explicit-type-annotations-to-extension-callback-parameters-30b6d73d36508125b074f509aa38145f) by [Unito](https://www.unito.io)
67 lines
2.0 KiB
TypeScript
67 lines
2.0 KiB
TypeScript
import type { LGraphNode } from '@/lib/litegraph/src/LGraphNode'
|
|
import type { ComfyNodeDef } from '@/schemas/nodeDefSchema'
|
|
import { applyTextReplacements } from '@/utils/searchAndReplace'
|
|
|
|
import { app } from '../../scripts/app'
|
|
|
|
const saveNodeTypes = new Set([
|
|
'SaveImage',
|
|
'SaveVideo',
|
|
'SaveAnimatedWEBP',
|
|
'SaveWEBM',
|
|
'SaveAudio',
|
|
'SaveGLB',
|
|
'SaveAnimatedPNG',
|
|
'CLIPSave',
|
|
'VAESave',
|
|
'ModelSave',
|
|
'LoraSave',
|
|
'SaveLatent'
|
|
])
|
|
|
|
// Use widget values and dates in output filenames
|
|
|
|
app.registerExtension({
|
|
name: 'Comfy.SaveImageExtraOutput',
|
|
async beforeRegisterNodeDef(
|
|
nodeType: typeof LGraphNode,
|
|
nodeData: ComfyNodeDef
|
|
) {
|
|
if (saveNodeTypes.has(nodeData.name)) {
|
|
const onNodeCreated = nodeType.prototype.onNodeCreated
|
|
// When the SaveImage node is created we want to override the serialization of the output name widget to run our S&R
|
|
nodeType.prototype.onNodeCreated = function () {
|
|
const r = onNodeCreated
|
|
? // @ts-expect-error fixme ts strict error
|
|
onNodeCreated.apply(this, arguments)
|
|
: undefined
|
|
|
|
// @ts-expect-error fixme ts strict error
|
|
const widget = this.widgets.find((w) => w.name === 'filename_prefix')
|
|
// @ts-expect-error fixme ts strict error
|
|
widget.serializeValue = () => {
|
|
// @ts-expect-error fixme ts strict error
|
|
return applyTextReplacements(app.graph, widget.value)
|
|
}
|
|
|
|
return r
|
|
}
|
|
} else {
|
|
// When any other node is created add a property to alias the node
|
|
const onNodeCreated = nodeType.prototype.onNodeCreated
|
|
nodeType.prototype.onNodeCreated = function () {
|
|
const r = onNodeCreated
|
|
? // @ts-expect-error fixme ts strict error
|
|
onNodeCreated.apply(this, arguments)
|
|
: undefined
|
|
|
|
if (!this.properties || !('Node name for S&R' in this.properties)) {
|
|
this.addProperty('Node name for S&R', this.constructor.type, 'string')
|
|
}
|
|
|
|
return r
|
|
}
|
|
}
|
|
}
|
|
})
|