mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-07-15 03:37:48 +00:00
95b121bed9
## Summary Fix the website-e2e job, red on main since 2026-07-07 15:19 UTC, by updating the cloud model-card count test and regenerating stale visual screenshot goldens. ## Context website-e2e runs Playwright tests against the marketing site (`apps/website`). It broke on main in two independent ways, so every PR since — however unrelated — has shown a red website-e2e check: 1. **Model-card count.** #13431 added a sixth model card (GPT Image 2) to the /cloud "AI models" section but didn't update the test that pins the card count at 5. CI: `locator resolved to 6 elements`. 2. **Stale screenshot goldens.** #13431 also swapped the ProductCard CTA to the shared `Button` (`whitespace-nowrap`, so e.g. "SEE ENTERPRISE FEATURES" renders on one line instead of wrapping) and committed matching `home-product-cards-*` goldens. Minutes later #13445 — a branch cut from main *before* #13431 — ran the screenshot-regen workflow, which checks out the raw PR branch, not the branch merged with main. Its regenerated lg/xl goldens therefore depict the **old** pre-#13431 card (wrapped label; pixel-identical layout to the pre-#13431 golden), and overwrote #13431's correct ones at merge. #13445's own website-e2e was red at merge time for exactly this reason. The sm/md goldens (last captured by #13431, without #13445's `ppformula-text-center` 0.19em→0.1em nudge) went stale by ~900 px the moment #13445 landed. ## Changes - **What**: `cloud.spec.ts` — model-card count assertion and test title 5 → 6 (verified against the 6 entries in `AIModelsSection.vue`; passes locally). - **What**: `ProductCard.vue` — `h-auto whitespace-normal` on the CTA `Button`. The shared Button's `whitespace-nowrap` made long labels ("SEE ENTERPRISE FEATURES") overflow past the card edge at lg/xl (live on prod since #13431); labels now wrap inside the card as they did before #13431. - **What**: regenerated `home-product-cards-*` goldens via the `Update Website Screenshots` workflow, run on this branch, so they capture the fixed rendering rather than enshrining the overflow. ## Review Focus - At lg, "SEE DESKTOP/CLOUD FEATURES" now also wrap to two lines: #13431 raised the CTA font from `text-xs` to `md:text-sm`, so those labels no longer fit one line in the 200px content box either (pre-fix they silently consumed the card padding). If design prefers one-liners, shrinking the CTA font is a follow-up. - Process gaps this incident exposed (follow-ups, not in this PR): the regen workflow captures against the raw branch instead of the main-merged result, and website-e2e was red on #13445 at merge without blocking it. --- *Six cards where five once stood,* *a button's text sat where it should —* *but pixels pinned in amber lied,* *so Linux looked, and rectified.* --------- Co-authored-by: github-actions <github-actions@github.com>