mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
f1bb756929
## Summary Alright, alright, alright. These e2e tests have been runnin' around like they're late for somethin', settin' tight little timeouts like the world's gonna end in 250 milliseconds. Man, you gotta *breathe*. Let the framework do its thing. Go slow to go fast, that's what I always say. ## Changes - **What**: Removed ~120 redundant timeout overrides from auto-retrying Playwright assertions (`toBeVisible`, `toBeHidden`, `toHaveCount`, `toBeEnabled`, `toHaveAttribute`, `toContainText`, `expect.poll`) where 5000ms is already the default. Also removed sub-5s timeouts (1s, 2s, 3s) that were just *begging* for flaky failures — like wearin' a belt and suspenders and also holdin' your pants up with both hands. Raised the absurdly short timeouts in `customMatchers.ts` (250ms `toPass` → 5000ms, 256ms poll → default). Kept `timeout: 5000` on `.toPass()` calls (defaults to 0), `.waitFor()`, `waitForRequest`, `waitForFunction`, intentionally-short timeouts inside retry loops, and conditional `.isVisible()/.catch()` checks — those fellas actually need the help. ## Review Focus Every remaining timeout in the diff is there for a *reason*. The ones on `.toPass()` stay because that API defaults to zero — it won't retry at all without one. The ones on `.waitFor()` and `waitForRequest` stay because those are locator actions, not auto-retrying assertions. The intentionally-short ones inside `toPass` retry loops (`interaction.spec.ts`) and the negative assertions (`actionbar.spec.ts` confirming no response arrives) — those are *supposed* to be tight. The short timeouts on regular assertions were actively *encouragin'* flaky failures. That's like settin' your alarm for 4 AM and then gettin' mad you're tired. Just... don't do that, man. Let things take the time they need. 38 files, net -115 lines. Less code, more chill. That's livin'. --------- Co-authored-by: Amp <amp@ampcode.com>
95 lines
2.2 KiB
TypeScript
95 lines
2.2 KiB
TypeScript
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
/** One representative of each widget type from the default workflow. */
|
|
type WidgetType = 'textarea' | 'number' | 'select' | 'text'
|
|
|
|
const WIDGET_TEST_DATA: {
|
|
nodeId: string
|
|
widgetName: string
|
|
type: WidgetType
|
|
fill: string
|
|
expected: unknown
|
|
}[] = [
|
|
{
|
|
nodeId: '6',
|
|
widgetName: 'text',
|
|
type: 'textarea',
|
|
fill: 'test prompt',
|
|
expected: 'test prompt'
|
|
},
|
|
{
|
|
nodeId: '5',
|
|
widgetName: 'width',
|
|
type: 'number',
|
|
fill: '768',
|
|
expected: 768
|
|
},
|
|
{
|
|
nodeId: '3',
|
|
widgetName: 'cfg',
|
|
type: 'number',
|
|
fill: '3.5',
|
|
expected: 3.5
|
|
},
|
|
{
|
|
nodeId: '3',
|
|
widgetName: 'sampler_name',
|
|
type: 'select',
|
|
fill: 'uni_pc',
|
|
expected: 'uni_pc'
|
|
},
|
|
{
|
|
nodeId: '9',
|
|
widgetName: 'filename_prefix',
|
|
type: 'text',
|
|
fill: 'test_prefix',
|
|
expected: 'test_prefix'
|
|
}
|
|
]
|
|
|
|
test.describe('App mode widget values in prompt', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.appMode.enableLinearMode()
|
|
})
|
|
|
|
test('Widget values are sent correctly in prompt POST', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { appMode } = comfyPage
|
|
const inputs: [string, string][] = WIDGET_TEST_DATA.map(
|
|
({ nodeId, widgetName }) => [nodeId, widgetName]
|
|
)
|
|
await appMode.enterAppModeWithInputs(inputs)
|
|
await expect(appMode.linearWidgets).toBeVisible()
|
|
|
|
for (const { nodeId, widgetName, type, fill } of WIDGET_TEST_DATA) {
|
|
const key = `${nodeId}:${widgetName}`
|
|
switch (type) {
|
|
case 'textarea':
|
|
await appMode.widgets.fillTextarea(key, fill)
|
|
break
|
|
case 'number':
|
|
await appMode.widgets.fillNumber(key, fill)
|
|
break
|
|
case 'select':
|
|
await appMode.widgets.selectOption(key, fill)
|
|
break
|
|
case 'text':
|
|
await appMode.widgets.fillText(key, fill)
|
|
break
|
|
default:
|
|
throw new Error(`Unknown widget type: ${type satisfies never}`)
|
|
}
|
|
}
|
|
|
|
const prompt = await appMode.widgets.runAndCapturePrompt()
|
|
|
|
for (const { nodeId, widgetName, expected } of WIDGET_TEST_DATA) {
|
|
expect(prompt[nodeId].inputs[widgetName]).toBe(expected)
|
|
}
|
|
})
|
|
})
|