mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
127 lines
3.6 KiB
TypeScript
127 lines
3.6 KiB
TypeScript
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Queue Clear History Dialog', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setup()
|
|
await comfyPage.queuePanel.overlayToggle.click()
|
|
})
|
|
|
|
test('Dialog opens from queue panel history actions menu', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
})
|
|
|
|
test('Dialog shows confirmation message with title, description, and assets note', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
|
|
await expect(
|
|
dialog.getByText('Clear your job queue history?')
|
|
).toBeVisible()
|
|
|
|
await expect(
|
|
dialog.getByText(
|
|
'All the finished or failed jobs below will be removed from this Job queue panel.'
|
|
)
|
|
).toBeVisible()
|
|
|
|
await expect(
|
|
dialog.getByText(
|
|
'Assets generated by these jobs won\u2019t be deleted and can always be viewed from the assets panel.'
|
|
)
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Cancel button closes dialog without clearing history', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
|
|
let clearCalled = false
|
|
await comfyPage.page.route('**/api/history', (route) => {
|
|
if (route.request().method() === 'POST') {
|
|
clearCalled = true
|
|
}
|
|
return route.continue()
|
|
})
|
|
|
|
await dialog.getByRole('button', { name: 'Cancel' }).click()
|
|
await expect(dialog).toBeHidden()
|
|
expect(clearCalled).toBe(false)
|
|
|
|
await comfyPage.page.unroute('**/api/history')
|
|
})
|
|
|
|
test('Close (X) button closes dialog without clearing history', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
|
|
let clearCalled = false
|
|
await comfyPage.page.route('**/api/history', (route) => {
|
|
if (route.request().method() === 'POST') {
|
|
clearCalled = true
|
|
}
|
|
return route.continue()
|
|
})
|
|
|
|
await dialog.getByLabel('Close').click()
|
|
await expect(dialog).toBeHidden()
|
|
expect(clearCalled).toBe(false)
|
|
|
|
await comfyPage.page.unroute('**/api/history')
|
|
})
|
|
|
|
test('Confirm clears queue history and closes dialog', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
|
|
const clearPromise = comfyPage.page.waitForRequest(
|
|
(req) => req.url().includes('/api/history') && req.method() === 'POST'
|
|
)
|
|
|
|
await dialog.getByRole('button', { name: 'Clear' }).click()
|
|
|
|
const request = await clearPromise
|
|
expect(request.postDataJSON()).toEqual({ clear: true })
|
|
|
|
await expect(dialog).toBeHidden()
|
|
})
|
|
|
|
test('Dialog state resets after close and reopen', async ({ comfyPage }) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
await dialog.getByRole('button', { name: 'Cancel' }).click()
|
|
await expect(dialog).toBeHidden()
|
|
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
await expect(dialog).toBeVisible()
|
|
|
|
const clearButton = dialog.getByRole('button', { name: 'Clear' })
|
|
await expect(clearButton).toBeVisible()
|
|
await expect(clearButton).toBeEnabled()
|
|
})
|
|
})
|