mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-07-15 11:44:10 +00:00
060957d66c
## Summary On Cloud, `releaseStore.currentVersion` sourced `cloud_version` (e.g. `0.160.1`) while the `/releases` feed keys its entries by **ComfyUI** version (e.g. `0.27.1`). The what's-new popup compares the latest feed entry against the running version, so `0.27.1 < 0.160.1` read as "already ahead of the latest release" and the popup never showed. - Analytics confirmed the regression: `release_note` clicks fell from **13.4% (90d) → 0% (30d)**; `cloud_release_note` was effectively never clicked. ## Change - `currentVersion` always uses `comfyui_version` (drops the `isCloud → cloud_version` branch). The feed request keeps `project: 'cloud'`. - Rationale: the changelog page and each note's "learn more" link are ComfyUI-versioned, and Cloud has no separate versioned feed or changelog page. The changelog is maintained with ComfyUI versions, updated after each Cloud deploy lands. ## Tests - Adds a regression test (`isCloud environment (FE-1237)`) pinning that Cloud uses `comfyui_version`, not `cloud_version`. Verified via negative control: reverting the fix fails it with `0.160.1` vs expected `0.27.1`. - `test:unit` (releaseStore): 49 passed · `typecheck`, `lint`, `format:check`, `knip`: clean. ## ADR Adds `docs/adr/0012-cloud-release-notes-use-comfyui-version.md` (Accepted) recording the rationale and history, and updates the ADR index. Fixes FE-1237 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Architecture Decision Records
This directory contains Architecture Decision Records (ADRs) for the ComfyUI Frontend project.
What is an ADR?
An Architecture Decision Record captures an important architectural decision made along with its context and consequences. ADRs help future developers understand why certain decisions were made and provide a historical record of the project's evolution.
ADR Index
| ADR | Title | Status | Date |
|---|---|---|---|
| 0001 | Merge LiteGraph.js into ComfyUI Frontend | Accepted | 2025-08-05 |
| 0002 | Restructure as a Monorepo | Accepted | 2025-08-25 |
| 0003 | Centralized Layout Management with CRDT | Proposed | 2025-08-27 |
| 0004 | Fork PrimeVue UI Library | Rejected | 2025-08-27 |
| 0005 | Remove Import Map for Vue Extensions | Accepted | 2025-12-13 |
| 0006 | PrimitiveNode Copy/Paste Lifecycle | Proposed | 2026-02-22 |
| 0007 | NodeExecutionOutput Passthrough Schema | Accepted | 2026-03-11 |
| 0008 | Entity Component System | Proposed | 2026-03-23 |
| 0009 | Subgraph Promoted Widgets Use Linked Inputs | Proposed | 2026-05-05 |
| 0010 | Remove Nx Orchestration | Accepted | 2026-05-19 |
| 0011 | Derived Credential Lifecycle for Cloud Auth | Proposed | 2026-07-09 |
| 0012 | Cloud Release Notes Use the ComfyUI Version | Accepted | 2026-07-13 |
Creating a New ADR
- Copy the template below
- Name it with the next number in sequence:
NNNN-descriptive-title.md - Fill in all sections
- Update this index
- Submit as part of your PR
ADR Template
# N. Title
Date: YYYY-MM-DD
## Status
[Proposed | Accepted | Rejected | Deprecated | Superseded by [ADR-NNNN](NNNN-title.md)]
## Context
Describe the issue that motivated this decision and any context that influences or constrains the decision.
- What is the problem?
- Why does it need to be solved?
- What forces are at play (technical, business, team)?
## Decision
Describe the decision that was made and the key points that led to it.
- What are we going to do?
- How will we do it?
- What alternatives were considered?
## Consequences
### Positive
- What becomes easier or better?
- What opportunities does this create?
### Negative
- What becomes harder or worse?
- What risks are we accepting?
- What technical debt might we incur?
## Notes
Optional section for additional information, references, or clarifications.
ADR Status Values
- Proposed: The decision is being discussed
- Accepted: The decision has been agreed upon
- Rejected: The decision was not accepted
- Deprecated: The decision is no longer relevant
- Superseded: The decision has been replaced by another ADR
Further Reading
- Documenting Architecture Decisions by Michael Nygard
- Architecture Decision Records - Collection of ADR resources