mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
f1db1122f3
## Summary Fix URI drops (e.g. dragging `<img>` thumbnails) onto Vue-rendered nodes by letting unhandled drops bubble to the document-level `text/uri-list` fallback in `app.ts`. ## Changes - **What**: Removed unconditional `.stop` modifier from `@drop` in `LGraphNode.vue`. `stopPropagation()` is now called conditionally — only when `onDragDrop` returns `true` (file drop handled). Made `handleDrop` synchronous since `onDragDrop` returns a plain boolean. ## Review Focus The key insight is that `onDragDrop` (from `useNodeDragAndDrop`) returns `false` synchronously for URI drags (no files in `DataTransfer`), so the event must bubble to reach the document handler that fetches the URI. The original `async` + `await` pattern would have deferred `stopPropagation` past the synchronous propagation phase, so `handleDrop` is now synchronous. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9463-fix-allow-URI-drops-to-bubble-from-Vue-nodes-to-document-handler-31b6d73d36508196a1b3f17e7e4837a9) by [Unito](https://www.unito.io)
111 lines
3.4 KiB
TypeScript
111 lines
3.4 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe(
|
|
'Load Workflow in Media',
|
|
{ tag: ['@screenshot', '@workflow'] },
|
|
() => {
|
|
const fileNames = [
|
|
'workflow.webp',
|
|
'edited_workflow.webp',
|
|
'no_workflow.webp',
|
|
'large_workflow.webp',
|
|
'workflow_prompt_parameters.png',
|
|
'workflow_itxt.png',
|
|
'workflow.webm',
|
|
// Skipped due to 3d widget unstable visual result.
|
|
// 3d widget shows grid after fully loaded.
|
|
// 'workflow.glb',
|
|
'workflow.mp4',
|
|
'workflow.mov',
|
|
'workflow.m4v',
|
|
'workflow.svg'
|
|
// TODO: Re-enable after fixing test asset to use core nodes only
|
|
// Currently opens missing nodes dialog which is outside scope of AVIF loading functionality
|
|
// 'workflow.avif'
|
|
]
|
|
const filesWithUpload = new Set(['no_workflow.webp'])
|
|
|
|
fileNames.forEach(async (fileName) => {
|
|
test(`Load workflow in ${fileName} (drop from filesystem)`, async ({
|
|
comfyPage
|
|
}) => {
|
|
const shouldUpload = filesWithUpload.has(fileName)
|
|
const uploadRequestPromise = shouldUpload
|
|
? comfyPage.page.waitForRequest((req) =>
|
|
req.url().includes('/upload/')
|
|
)
|
|
: null
|
|
|
|
await comfyPage.dragDrop.dragAndDropFile(`workflowInMedia/${fileName}`)
|
|
|
|
if (uploadRequestPromise) {
|
|
const request = await uploadRequestPromise
|
|
expect(request.url()).toContain('/upload/')
|
|
} else {
|
|
await expect(comfyPage.canvas).toHaveScreenshot(`${fileName}.png`)
|
|
}
|
|
})
|
|
})
|
|
|
|
const urls = [
|
|
'https://comfyanonymous.github.io/ComfyUI_examples/hidream/hidream_dev_example.png'
|
|
]
|
|
urls.forEach(async (url) => {
|
|
test(`Load workflow from URL ${url} (drop from different browser tabs)`, async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.dragDrop.dragAndDropURL(url)
|
|
const readableName = url.split('/').pop()
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
`dropped_workflow_url_${readableName}.png`
|
|
)
|
|
})
|
|
})
|
|
|
|
test('Load workflow from URL dropped onto Vue node', async ({
|
|
comfyPage
|
|
}) => {
|
|
const fakeUrl = 'https://example.com/workflow.png'
|
|
await comfyPage.page.route(fakeUrl, (route) =>
|
|
route.fulfill({
|
|
path: comfyPage.assetPath('workflowInMedia/workflow_itxt.png')
|
|
})
|
|
)
|
|
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
|
|
const initialNodeCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
|
|
const node = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
const box = await node.boundingBox()
|
|
expect(box).not.toBeNull()
|
|
|
|
const dropPosition = {
|
|
x: box!.x + box!.width / 2,
|
|
y: box!.y + box!.height / 2
|
|
}
|
|
|
|
await comfyPage.dragDrop.dragAndDropURL(fakeUrl, {
|
|
dropPosition,
|
|
preserveNativePropagation: true
|
|
})
|
|
|
|
await comfyPage.page.waitForFunction(
|
|
(prevCount) => window.app!.graph.nodes.length !== prevCount,
|
|
initialNodeCount,
|
|
{ timeout: 10000 }
|
|
)
|
|
|
|
const newNodeCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
expect(newNodeCount).not.toBe(initialNodeCount)
|
|
})
|
|
}
|
|
)
|