mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
*PR Created by the Glary-Bot Agent* --- ## Summary - Convert ~120 getter-based locators across 18 browser test fixture files to `public readonly` constructor-assigned properties - Removes unnecessary indirection, makes object shape explicit, and improves IDE auto-complete / type inference - Keeps lazy-init getters (`??=`), computed properties, and `private get page()` convenience accessors as getters ## Changes **`browser_tests/fixtures/components/`** (6 files): `ComfyNodeSearchBox`, `ContextMenu`, `SettingDialog`, `SignInDialog`, `SidebarTab` (all 6 classes), `Topbar` **`browser_tests/fixtures/`** (4 files): `ComfyPage` (ComfyMenu.buttons, ComfyPage.visibleToasts), `UserSelectPage`, `ComfyMouse`, `VueNodeHelpers` **`browser_tests/fixtures/helpers/`** (7 files): `AppModeHelper`, `BuilderFooterHelper`, `BuilderSaveAsHelper`, `BuilderSelectHelper`, `BuilderStepsHelper`, `ToastHelper`, `NodeOperationsHelper` **`browser_tests/fixtures/utils/`** (1 file): `vueNodeFixtures` ## Validation - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm exec eslint browser_tests/fixtures/` ✅ - All pre-commit hooks pass (oxfmt, oxlint, eslint, typecheck, typecheck:browser) ✅ - No visual/manual verification needed — changes are test fixture locator declarations only (no UI or runtime behavior change) Fixes #11131 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11135-refactor-standardize-Page-Object-locators-as-public-readonly-instead-of-getters-33e6d73d3650819690cbc639f3d30daf) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
60 lines
1.8 KiB
TypeScript
60 lines
1.8 KiB
TypeScript
import type { Locator } from '@playwright/test'
|
|
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
/** DOM-centric helper for a single Vue-rendered node on the canvas. */
|
|
export class VueNodeFixture {
|
|
public readonly header: Locator
|
|
public readonly title: Locator
|
|
public readonly titleInput: Locator
|
|
public readonly body: Locator
|
|
public readonly pinIndicator: Locator
|
|
public readonly collapseButton: Locator
|
|
public readonly collapseIcon: Locator
|
|
public readonly root: Locator
|
|
|
|
constructor(private readonly locator: Locator) {
|
|
this.header = locator.locator('[data-testid^="node-header-"]')
|
|
this.title = locator.locator('[data-testid="node-title"]')
|
|
this.titleInput = locator.locator('[data-testid="node-title-input"]')
|
|
this.body = locator.locator('[data-testid^="node-body-"]')
|
|
this.pinIndicator = locator.getByTestId(TestIds.node.pinIndicator)
|
|
this.collapseButton = locator.locator(
|
|
'[data-testid="node-collapse-button"]'
|
|
)
|
|
this.collapseIcon = this.collapseButton.locator('i')
|
|
this.root = locator
|
|
}
|
|
|
|
async getTitle(): Promise<string> {
|
|
return (await this.title.textContent()) ?? ''
|
|
}
|
|
|
|
async setTitle(value: string): Promise<void> {
|
|
await this.header.dblclick()
|
|
const input = this.titleInput
|
|
await input.waitFor({ state: 'visible' })
|
|
await input.fill(value)
|
|
await input.press('Enter')
|
|
}
|
|
|
|
async cancelTitleEdit(): Promise<void> {
|
|
await this.header.dblclick()
|
|
const input = this.titleInput
|
|
await input.waitFor({ state: 'visible' })
|
|
await input.press('Escape')
|
|
}
|
|
|
|
async toggleCollapse(): Promise<void> {
|
|
await this.collapseButton.click()
|
|
}
|
|
|
|
async getCollapseIconClass(): Promise<string> {
|
|
return (await this.collapseIcon.getAttribute('class')) ?? ''
|
|
}
|
|
|
|
boundingBox(): ReturnType<Locator['boundingBox']> {
|
|
return this.locator.boundingBox()
|
|
}
|
|
}
|