mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
106 lines
3.1 KiB
TypeScript
106 lines
3.1 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
import { openErrorsTabViaSeeErrors } from '@e2e/tests/propertiesPanel/ErrorsTabHelper'
|
|
|
|
test.describe('Errors tab - Missing nodes', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.RightSidePanel.ShowErrorsTab',
|
|
true
|
|
)
|
|
})
|
|
|
|
test('Should show MissingNodeCard in errors tab', async ({ comfyPage }) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_nodes')
|
|
|
|
await expect(
|
|
comfyPage.page.getByTestId(TestIds.dialogs.missingNodeCard)
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Should show missing node packs group', async ({ comfyPage }) => {
|
|
await openErrorsTabViaSeeErrors(comfyPage, 'missing/missing_nodes')
|
|
|
|
await expect(
|
|
comfyPage.page.getByTestId(TestIds.dialogs.missingNodePacksGroup)
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Should expand pack group to reveal node type names', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(
|
|
comfyPage,
|
|
'missing/missing_nodes_in_subgraph'
|
|
)
|
|
|
|
const missingNodeCard = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.missingNodeCard
|
|
)
|
|
await expect(missingNodeCard).toBeVisible()
|
|
|
|
await missingNodeCard
|
|
.getByRole('button', { name: /expand/i })
|
|
.first()
|
|
.click()
|
|
await expect(
|
|
missingNodeCard.getByText('MISSING_NODE_TYPE_IN_SUBGRAPH')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Should collapse expanded pack group', async ({ comfyPage }) => {
|
|
await openErrorsTabViaSeeErrors(
|
|
comfyPage,
|
|
'missing/missing_nodes_in_subgraph'
|
|
)
|
|
|
|
const missingNodeCard = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.missingNodeCard
|
|
)
|
|
await missingNodeCard
|
|
.getByRole('button', { name: /expand/i })
|
|
.first()
|
|
.click()
|
|
await expect(
|
|
missingNodeCard.getByText('MISSING_NODE_TYPE_IN_SUBGRAPH')
|
|
).toBeVisible()
|
|
|
|
await missingNodeCard
|
|
.getByRole('button', { name: /collapse/i })
|
|
.first()
|
|
.click()
|
|
await expect(
|
|
missingNodeCard.getByText('MISSING_NODE_TYPE_IN_SUBGRAPH')
|
|
).not.toBeVisible()
|
|
})
|
|
|
|
test('Locate node button is visible for expanded pack nodes', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openErrorsTabViaSeeErrors(
|
|
comfyPage,
|
|
'missing/missing_nodes_in_subgraph'
|
|
)
|
|
|
|
const missingNodeCard = comfyPage.page.getByTestId(
|
|
TestIds.dialogs.missingNodeCard
|
|
)
|
|
await missingNodeCard
|
|
.getByRole('button', { name: /expand/i })
|
|
.first()
|
|
.click()
|
|
|
|
const locateButton = missingNodeCard.getByRole('button', {
|
|
name: /locate/i
|
|
})
|
|
await expect(locateButton.first()).toBeVisible()
|
|
// TODO: Add navigation assertion once subgraph node ID deduplication
|
|
// timing is fixed. Currently, collectMissingNodes runs before
|
|
// configure(), so execution IDs use pre-remapped node IDs that don't
|
|
// match the runtime graph. See PR #9510 / #8762.
|
|
})
|
|
})
|