mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-27 18:24:11 +00:00
## Summary Add a permanent, non-failing performance regression detection system using Chrome DevTools Protocol metrics, with automatic PR commenting. ## Changes - **What**: Performance testing infrastructure — `PerformanceHelper` fixture class using CDP `Performance.getMetrics` to collect `RecalcStyleCount`, `LayoutCount`, `LayoutDuration`, `TaskDuration`, `JSHeapUsedSize`. Adds `@perf` Playwright project (Chromium-only, single-threaded, 60s timeout), 4 baseline perf tests, CI workflow with sticky PR comment reporting, and `perf-report.js` script for generating markdown comparison tables. ## Review Focus - `PerformanceHelper` uses `page.context().newCDPSession(page)` — CDP is Chromium-only, so perf metrics are not collected on Firefox. This is intentional since CDP gives us browser-level style recalc/layout counts that `performance.mark/measure` cannot capture. - The CI workflow uses `continue-on-error: true` so perf tests never block merging. - Baseline comparison uses `dawidd6/action-download-artifact` to download metrics from the target branch, following the same pattern as `pr-size-report.yaml`. ## Stack This is the foundation PR for the Firefox performance fix stack: 1. **→ This PR: perf testing infrastructure** 2. `perf/fix-cursor-cache` — cursor style caching (depends on this) 3. `perf/fix-subgraph-svg` — SVG pre-rasterization (depends on this) 4. `perf/fix-clippath-raf` — RAF batching for clip-path (depends on this) PRs 2-4 are independent of each other. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9170-feat-add-performance-testing-infrastructure-with-CDP-metrics-3116d73d3650817cb43def6f8e9917f8) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
97 lines
2.6 KiB
TypeScript
97 lines
2.6 KiB
TypeScript
import type { CDPSession, Page } from '@playwright/test'
|
|
|
|
interface PerfSnapshot {
|
|
RecalcStyleCount: number
|
|
RecalcStyleDuration: number
|
|
LayoutCount: number
|
|
LayoutDuration: number
|
|
TaskDuration: number
|
|
JSHeapUsedSize: number
|
|
Timestamp: number
|
|
}
|
|
|
|
export interface PerfMeasurement {
|
|
name: string
|
|
durationMs: number
|
|
styleRecalcs: number
|
|
styleRecalcDurationMs: number
|
|
layouts: number
|
|
layoutDurationMs: number
|
|
taskDurationMs: number
|
|
heapDeltaBytes: number
|
|
}
|
|
|
|
export class PerformanceHelper {
|
|
private cdp: CDPSession | null = null
|
|
private snapshot: PerfSnapshot | null = null
|
|
|
|
constructor(private readonly page: Page) {}
|
|
|
|
async init(): Promise<void> {
|
|
this.cdp = await this.page.context().newCDPSession(this.page)
|
|
await this.cdp.send('Performance.enable')
|
|
}
|
|
|
|
async dispose(): Promise<void> {
|
|
this.snapshot = null
|
|
if (this.cdp) {
|
|
try {
|
|
await this.cdp.send('Performance.disable')
|
|
} finally {
|
|
await this.cdp.detach()
|
|
this.cdp = null
|
|
}
|
|
}
|
|
}
|
|
|
|
private async getSnapshot(): Promise<PerfSnapshot> {
|
|
if (!this.cdp) throw new Error('PerformanceHelper not initialized')
|
|
const { metrics } = (await this.cdp.send('Performance.getMetrics')) as {
|
|
metrics: { name: string; value: number }[]
|
|
}
|
|
function get(name: string): number {
|
|
return metrics.find((m) => m.name === name)?.value ?? 0
|
|
}
|
|
return {
|
|
RecalcStyleCount: get('RecalcStyleCount'),
|
|
RecalcStyleDuration: get('RecalcStyleDuration'),
|
|
LayoutCount: get('LayoutCount'),
|
|
LayoutDuration: get('LayoutDuration'),
|
|
TaskDuration: get('TaskDuration'),
|
|
JSHeapUsedSize: get('JSHeapUsedSize'),
|
|
Timestamp: get('Timestamp')
|
|
}
|
|
}
|
|
|
|
async startMeasuring(): Promise<void> {
|
|
if (this.snapshot) {
|
|
throw new Error(
|
|
'Measurement already in progress — call stopMeasuring() first'
|
|
)
|
|
}
|
|
this.snapshot = await this.getSnapshot()
|
|
}
|
|
|
|
async stopMeasuring(name: string): Promise<PerfMeasurement> {
|
|
if (!this.snapshot) throw new Error('Call startMeasuring() first')
|
|
const after = await this.getSnapshot()
|
|
const before = this.snapshot
|
|
this.snapshot = null
|
|
|
|
function delta(key: keyof PerfSnapshot): number {
|
|
return after[key] - before[key]
|
|
}
|
|
|
|
return {
|
|
name,
|
|
durationMs: delta('Timestamp') * 1000,
|
|
styleRecalcs: delta('RecalcStyleCount'),
|
|
styleRecalcDurationMs: delta('RecalcStyleDuration') * 1000,
|
|
layouts: delta('LayoutCount'),
|
|
layoutDurationMs: delta('LayoutDuration') * 1000,
|
|
taskDurationMs: delta('TaskDuration') * 1000,
|
|
heapDeltaBytes: delta('JSHeapUsedSize')
|
|
}
|
|
}
|
|
}
|