mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
033b3dad3a
## Summary
Adds a GitHub Actions workflow + TypeScript script that posts to Slack
when a merged PR improves unit or E2E test coverage.
## Changes
- **What**: New `coverage-slack-notify.yaml` workflow triggered on push
to main. Compares current coverage against previous baselines, generates
Slack Block Kit payload with progress bars and milestone celebrations,
posts to `#p-frontend-automated-testing`.
- **Script**: `scripts/coverage-slack-notify.ts` — parses lcov files,
computes deltas, detects milestone crossings (every 5%), builds Slack
payload. Pure functions exported for testability.
- **Tests**: 26 unit tests in `scripts/coverage-slack-notify.test.ts`
covering all pure functions including edge cases (malformed lcov, exact
boundaries, zero coverage).
### Security hardening
- All `${{ }}` expressions moved from `run:` blocks to `env:` variables
- `SLACK_BOT_TOKEN` passed via env var, not inline
- Unique heredoc delimiter (timestamp-based) prevents payload injection
- `parseInt` fallback (`|| 0`) guards against malformed lcov
- PR regex anchored to first line of commit message
### Robustness
- `continue-on-error: true` on Slack post step (outage does not fail the
job)
- Baseline save guarded by `steps.unit-tests.outcome == success`
(prevents corrupt baselines on test failure)
- Channel ID commented for maintainability
- Top-level `text` field added for Slack mobile push notifications
- Author linked to GitHub profile instead of bare `@username`
## Review Focus
- Workflow step ordering and conditional logic
- Security of expression handling and secret management
- Slack payload structure and Block Kit formatting
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10977-feat-add-Slack-notification-workflow-for-coverage-improvements-33d6d73d3650819c8950f483c83f297c)
by [Unito](https://www.unito.io)
---------
Co-authored-by: GitHub Action <action@github.com>
66 lines
1.9 KiB
YAML
66 lines
1.9 KiB
YAML
name: Find Workflow Run
|
|
description: Finds a workflow run for a given commit SHA and outputs its status and run ID.
|
|
|
|
inputs:
|
|
workflow-id:
|
|
description: The workflow filename (e.g., 'ci-size-data.yaml')
|
|
required: true
|
|
head-sha:
|
|
description: The commit SHA to find runs for
|
|
required: true
|
|
not-found-status:
|
|
description: Status to output when no run exists
|
|
required: false
|
|
default: pending
|
|
token:
|
|
description: GitHub token for API access
|
|
required: true
|
|
|
|
outputs:
|
|
status:
|
|
description: One of 'ready', 'pending', 'failed', or the not-found-status value
|
|
value: ${{ steps.find.outputs.status }}
|
|
run-id:
|
|
description: The workflow run ID (only set when status is 'ready')
|
|
value: ${{ steps.find.outputs.run-id }}
|
|
|
|
runs:
|
|
using: composite
|
|
steps:
|
|
- name: Find workflow run
|
|
id: find
|
|
uses: actions/github-script@v8
|
|
env:
|
|
WORKFLOW_ID: ${{ inputs.workflow-id }}
|
|
HEAD_SHA: ${{ inputs.head-sha }}
|
|
NOT_FOUND_STATUS: ${{ inputs.not-found-status }}
|
|
with:
|
|
github-token: ${{ inputs.token }}
|
|
script: |
|
|
const { data: runs } = await github.rest.actions.listWorkflowRuns({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
workflow_id: process.env.WORKFLOW_ID,
|
|
head_sha: process.env.HEAD_SHA,
|
|
per_page: 1,
|
|
});
|
|
|
|
const run = runs.workflow_runs[0];
|
|
if (!run) {
|
|
core.setOutput('status', process.env.NOT_FOUND_STATUS);
|
|
return;
|
|
}
|
|
|
|
if (run.status !== 'completed') {
|
|
core.setOutput('status', 'pending');
|
|
return;
|
|
}
|
|
|
|
if (run.conclusion !== 'success') {
|
|
core.setOutput('status', 'failed');
|
|
return;
|
|
}
|
|
|
|
core.setOutput('status', 'ready');
|
|
core.setOutput('run-id', String(run.id));
|