mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-12 08:50:17 +00:00
25f493bd30
## Summary Adds 6 @cloud-tagged Playwright tests covering the assets sidebar sort menu (newest/oldest/longest/fastest). Phase 4 of the assets-test plan. **Stacked on #11632** — base will retarget to \`main\` once the foundation PR merges. Independent of #11633 (filter E2E) and can be reviewed in parallel. ## Changes - **What**: New file `browser_tests/tests/sidebar/assets-sort.spec.ts`. Uses the `createJobsWithExecutionTimes()` factory and the `sortLongestFirst` / `sortFastestFirst` locators added in #11632. - **Coverage**: - Settings menu exposes all four sort options in cloud mode - Default order is newest first (descending `create_time`) - "Oldest first" reverses the order - "Longest first" puts the slowest execution at the top - "Fastest first" puts the quickest execution at the top - Sort persists across search-input edits - **Breaking**: none ## Review Focus - **Misaligned (create_time, duration) axes**: fixture data is deliberately constructed so newest/oldest and longest/fastest produce distinct orderings — no test can false-pass by satisfying a different sort. See the table comment at the top of the spec. - **`@cloud` tag is required**: sort options are gated behind `:show-sort-options="isCloud"`, which depends on the compile-time `__DISTRIBUTION__` flag. Tests run only against the `cloud` Playwright project. - **Local verification needed**: maintainer should verify with `pnpm dev:cloud` + `pnpm test:browser:local --project cloud --grep "sort options"` before merging — I could not run the cloud dev server end-to-end in my environment. Fixes #10779 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11634-test-assets-add-E2E-spec-for-sort-options-34e6d73d365081a79facde5bde2e18c6) by [Unito](https://www.unito.io)