mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
Add 4 new metrics from CDP Performance.getMetrics that are already returned but were not being collected: - domNodes (CDP Nodes): DOM node count delta — critical for detecting widget DOM leaks during node creation/destruction - jsHeapTotalBytes (CDP JSHeapTotalSize): total heap size delta — combined with heapDeltaBytes shows GC pressure and fragmentation - scriptDurationMs (CDP ScriptDuration): JS execution time separate from total task duration — reveals script vs rendering balance - eventListeners (CDP JSEventListeners): event listener count delta — detects listener accumulation across widget lifecycle 3 of the 4 new metrics (domNodes, scriptDurationMs, eventListeners) are added to REPORTED_METRICS for PR report display. jsHeapTotalBytes is collected but used alongside heapDeltaBytes for GC pressure analysis, not standalone.
113 lines
3.2 KiB
TypeScript
113 lines
3.2 KiB
TypeScript
import type { CDPSession, Page } from '@playwright/test'
|
|
|
|
interface PerfSnapshot {
|
|
RecalcStyleCount: number
|
|
RecalcStyleDuration: number
|
|
LayoutCount: number
|
|
LayoutDuration: number
|
|
TaskDuration: number
|
|
JSHeapUsedSize: number
|
|
Timestamp: number
|
|
Nodes: number
|
|
JSHeapTotalSize: number
|
|
ScriptDuration: number
|
|
JSEventListeners: number
|
|
}
|
|
|
|
export interface PerfMeasurement {
|
|
name: string
|
|
durationMs: number
|
|
styleRecalcs: number
|
|
styleRecalcDurationMs: number
|
|
layouts: number
|
|
layoutDurationMs: number
|
|
taskDurationMs: number
|
|
heapDeltaBytes: number
|
|
domNodes: number
|
|
jsHeapTotalBytes: number
|
|
scriptDurationMs: number
|
|
eventListeners: number
|
|
}
|
|
|
|
export class PerformanceHelper {
|
|
private cdp: CDPSession | null = null
|
|
private snapshot: PerfSnapshot | null = null
|
|
|
|
constructor(private readonly page: Page) {}
|
|
|
|
async init(): Promise<void> {
|
|
this.cdp = await this.page.context().newCDPSession(this.page)
|
|
await this.cdp.send('Performance.enable')
|
|
}
|
|
|
|
async dispose(): Promise<void> {
|
|
this.snapshot = null
|
|
if (this.cdp) {
|
|
try {
|
|
await this.cdp.send('Performance.disable')
|
|
} finally {
|
|
await this.cdp.detach()
|
|
this.cdp = null
|
|
}
|
|
}
|
|
}
|
|
|
|
private async getSnapshot(): Promise<PerfSnapshot> {
|
|
if (!this.cdp) throw new Error('PerformanceHelper not initialized')
|
|
const { metrics } = (await this.cdp.send('Performance.getMetrics')) as {
|
|
metrics: { name: string; value: number }[]
|
|
}
|
|
function get(name: string): number {
|
|
return metrics.find((m) => m.name === name)?.value ?? 0
|
|
}
|
|
return {
|
|
RecalcStyleCount: get('RecalcStyleCount'),
|
|
RecalcStyleDuration: get('RecalcStyleDuration'),
|
|
LayoutCount: get('LayoutCount'),
|
|
LayoutDuration: get('LayoutDuration'),
|
|
TaskDuration: get('TaskDuration'),
|
|
JSHeapUsedSize: get('JSHeapUsedSize'),
|
|
Timestamp: get('Timestamp'),
|
|
Nodes: get('Nodes'),
|
|
JSHeapTotalSize: get('JSHeapTotalSize'),
|
|
ScriptDuration: get('ScriptDuration'),
|
|
JSEventListeners: get('JSEventListeners')
|
|
}
|
|
}
|
|
|
|
async startMeasuring(): Promise<void> {
|
|
if (this.snapshot) {
|
|
throw new Error(
|
|
'Measurement already in progress — call stopMeasuring() first'
|
|
)
|
|
}
|
|
this.snapshot = await this.getSnapshot()
|
|
}
|
|
|
|
async stopMeasuring(name: string): Promise<PerfMeasurement> {
|
|
if (!this.snapshot) throw new Error('Call startMeasuring() first')
|
|
const after = await this.getSnapshot()
|
|
const before = this.snapshot
|
|
this.snapshot = null
|
|
|
|
function delta(key: keyof PerfSnapshot): number {
|
|
return after[key] - before[key]
|
|
}
|
|
|
|
return {
|
|
name,
|
|
durationMs: delta('Timestamp') * 1000,
|
|
styleRecalcs: delta('RecalcStyleCount'),
|
|
styleRecalcDurationMs: delta('RecalcStyleDuration') * 1000,
|
|
layouts: delta('LayoutCount'),
|
|
layoutDurationMs: delta('LayoutDuration') * 1000,
|
|
taskDurationMs: delta('TaskDuration') * 1000,
|
|
heapDeltaBytes: delta('JSHeapUsedSize'),
|
|
domNodes: delta('Nodes'),
|
|
jsHeapTotalBytes: delta('JSHeapTotalSize'),
|
|
scriptDurationMs: delta('ScriptDuration') * 1000,
|
|
eventListeners: delta('JSEventListeners')
|
|
}
|
|
}
|
|
}
|