mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
## Summary Add 2 reusable test helpers for Playwright E2E tests, integrated into the ComfyPage fixture. These provide standardized patterns for mocking feature flags and queue state across all E2E tests. ## Changes - **`FeatureFlagHelper.ts`** — manage localStorage `ff:` prefixed feature flags (`seedFlags` for init-time, `setFlags` for runtime) and mock `/api/features` route - **`QueueHelper.ts`** — mock `/api/queue` and `/api/history` routes with configurable running/pending counts and success/error job entries - **`ComfyPage.ts`** — integrate both helpers as `comfyPage.featureFlags` and `comfyPage.queue` ## Review Focus - Helper API design: are `seedFlags`/`setFlags`/`mockServerFeatures` the right abstractions for feature flag testing? - Queue mock fidelity: does the mock history shape match real ComfyUI API responses closely enough? - These are test-only infrastructure — no production code changes. ## Stack This is the base PR for the Playwright E2E coverage stack. Waves 1-4 all branch from this and can merge independently once this lands: - **→ This PR**: Test infrastructure helpers - #9555: Toasts, error overlay, selection toolbox, linear mode, selection rectangle - #9556: Node search, bottom panel, focus mode, job history, side panel - #9557: Errors tab, node headers, queue notifications, settings sidebar - #9558: Minimap, widget copy, floating menus, node library essentials --------- Co-authored-by: GitHub Action <action@github.com>
74 lines
2.4 KiB
TypeScript
74 lines
2.4 KiB
TypeScript
import type { Page, Route } from '@playwright/test'
|
|
|
|
export class FeatureFlagHelper {
|
|
private featuresRouteHandler: ((route: Route) => void) | null = null
|
|
|
|
constructor(private readonly page: Page) {}
|
|
|
|
/**
|
|
* Seed feature flags via `addInitScript` so they are available in
|
|
* localStorage before the app JS executes on first load.
|
|
* Must be called before `comfyPage.setup()` / `page.goto()`.
|
|
*
|
|
* Note: Playwright init scripts persist for the page lifetime and
|
|
* cannot be removed. Call this once per test, before navigation.
|
|
*/
|
|
async seedFlags(flags: Record<string, unknown>): Promise<void> {
|
|
await this.page.addInitScript((flagMap: Record<string, unknown>) => {
|
|
for (const [key, value] of Object.entries(flagMap)) {
|
|
localStorage.setItem(`ff:${key}`, JSON.stringify(value))
|
|
}
|
|
}, flags)
|
|
}
|
|
|
|
/**
|
|
* Set feature flags at runtime via localStorage. Uses the `ff:` prefix
|
|
* that devFeatureFlagOverride.ts reads in dev mode.
|
|
* For flags needed before page init, use `seedFlags()` instead.
|
|
*/
|
|
async setFlags(flags: Record<string, unknown>): Promise<void> {
|
|
await this.page.evaluate((flagMap: Record<string, unknown>) => {
|
|
for (const [key, value] of Object.entries(flagMap)) {
|
|
localStorage.setItem(`ff:${key}`, JSON.stringify(value))
|
|
}
|
|
}, flags)
|
|
}
|
|
|
|
async setFlag(name: string, value: unknown): Promise<void> {
|
|
await this.setFlags({ [name]: value })
|
|
}
|
|
|
|
async clearFlags(): Promise<void> {
|
|
await this.page.evaluate(() => {
|
|
const keysToRemove: string[] = []
|
|
for (let i = 0; i < localStorage.length; i++) {
|
|
const key = localStorage.key(i)
|
|
if (key?.startsWith('ff:')) keysToRemove.push(key)
|
|
}
|
|
keysToRemove.forEach((k) => {
|
|
localStorage.removeItem(k)
|
|
})
|
|
})
|
|
}
|
|
|
|
/**
|
|
* Mock server feature flags via route interception on /api/features.
|
|
*/
|
|
async mockServerFeatures(features: Record<string, unknown>): Promise<void> {
|
|
this.featuresRouteHandler = (route: Route) =>
|
|
route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(features)
|
|
})
|
|
await this.page.route('**/api/features', this.featuresRouteHandler)
|
|
}
|
|
|
|
async clearMocks(): Promise<void> {
|
|
if (this.featuresRouteHandler) {
|
|
await this.page.unroute('**/api/features', this.featuresRouteHandler)
|
|
this.featuresRouteHandler = null
|
|
}
|
|
}
|
|
}
|