mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
7823cfc83e
## Summary Add 30 E2E tests across 5 spec files covering medium-impact UI interactions: node search V2, bottom panel logs, focus mode, job history actions, and right side panel tabs. ## Tests | Spec file | Tests | Coverage | |---|---|---| | `nodeSearchBoxV2Extended.spec.ts` | 6 | V2 search filtering, keyboard navigation, category display | | `bottomPanelLogs.spec.ts` | 6 | Bottom panel toggle, logs tab, xterm terminal rendering | | `focusMode.spec.ts` | 6 | Focus mode hide/show UI chrome, sidebar/menu visibility | | `jobHistoryActions.spec.ts` | 6 | More options popover, docked history panel, queue interactions | | `rightSidePanelTabs.spec.ts` | 6 | Properties panel, node details, search from side panel | ## Review Focus - Bottom panel logs tests interact with xterm.js — the approach uses terminal container visibility rather than text content assertions. Is this the right level of testing? - Focus mode tests verify UI element hiding — they check element count/visibility rather than visual regression. Appropriate? ## Stack Depends on #9554 for FeatureFlagHelper/QueueHelper infrastructure. - #9554: Test infrastructure helpers - #9555: Toasts, error overlay, selection toolbox, linear mode, selection rectangle - **→ This PR**: Node search, bottom panel, focus mode, job history, side panel - #9557: Errors tab, node headers, queue notifications, settings sidebar - #9558: Minimap, widget copy, floating menus, node library essentials
92 lines
2.6 KiB
TypeScript
92 lines
2.6 KiB
TypeScript
import type { Locator } from '@playwright/test'
|
|
|
|
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '../fixtures/ComfyPage'
|
|
|
|
test.describe('Job History Actions', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.setup()
|
|
|
|
// Expand the queue overlay so the JobHistoryActionsMenu is visible
|
|
await comfyPage.page.getByTestId('queue-overlay-toggle').click()
|
|
})
|
|
|
|
async function openMoreOptionsPopover(comfyPage: {
|
|
page: { getByLabel(label: string | RegExp): Locator }
|
|
}) {
|
|
const moreButton = comfyPage.page.getByLabel(/More options/i).first()
|
|
await moreButton.click()
|
|
}
|
|
|
|
test('More options popover opens', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="docked-job-history-action"]')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Docked job history action is visible with text', async ({
|
|
comfyPage
|
|
}) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.locator(
|
|
'[data-testid="docked-job-history-action"]'
|
|
)
|
|
await expect(action).toBeVisible()
|
|
await expect(action).not.toBeEmpty()
|
|
})
|
|
|
|
test('Show run progress bar action is visible', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="show-run-progress-bar-action"]')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Clear history action is visible', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.locator('[data-testid="clear-history-action"]')
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Clicking docked job history closes popover', async ({ comfyPage }) => {
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.locator(
|
|
'[data-testid="docked-job-history-action"]'
|
|
)
|
|
await expect(action).toBeVisible()
|
|
await action.click()
|
|
|
|
await expect(action).not.toBeVisible()
|
|
})
|
|
|
|
test('Clicking show run progress bar toggles setting', async ({
|
|
comfyPage
|
|
}) => {
|
|
const settingBefore = await comfyPage.settings.getSetting<boolean>(
|
|
'Comfy.Queue.ShowRunProgressBar'
|
|
)
|
|
|
|
await openMoreOptionsPopover(comfyPage)
|
|
|
|
const action = comfyPage.page.locator(
|
|
'[data-testid="show-run-progress-bar-action"]'
|
|
)
|
|
await action.click()
|
|
|
|
const settingAfter = await comfyPage.settings.getSetting<boolean>(
|
|
'Comfy.Queue.ShowRunProgressBar'
|
|
)
|
|
expect(settingAfter).toBe(!settingBefore)
|
|
})
|
|
})
|