mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 14:30:41 +00:00

Files

Christian Byrne 0e5bd539ec fix: 3D asset disappears when switching to image output in app mode (#9622 )

## Summary

Fix 3D asset disappearing when switching between 3D and image outputs in
app mode — missing `onUnmounted` cleanup leaked WebGL contexts.

## Changes

- **What**: Add `onUnmounted` hook to `Preview3d.vue` that calls
`viewer.cleanup()`, releasing the WebGL context when Vue destroys the
component via its v-if chain. Add unit tests covering init, cleanup on
unmount, and remount behavior.

## Review Focus

When switching outputs in app mode, Vue's v-if chain destroys and
recreates `Preview3d`. Without `onUnmounted` cleanup, the old `Load3d`
instance (WebGL context, RAF loop, ResizeObserver) leaks. After ~8-16
toggles, the browser's WebGL context limit is exhausted and new 3D
viewers silently fail to render.

<!-- Pipeline-Ticket: e36489d2-a9fb-47ca-9e27-88eb3170836b -->

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>

2026-03-18 01:08:04 +00:00

3.1 KiB

Raw Blame History

Architecture Decision Records

This directory contains Architecture Decision Records (ADRs) for the ComfyUI Frontend project.

What is an ADR?

An Architecture Decision Record captures an important architectural decision made along with its context and consequences. ADRs help future developers understand why certain decisions were made and provide a historical record of the project's evolution.

ADR Index

ADR	Title	Status	Date
0001	Merge LiteGraph.js into ComfyUI Frontend	Accepted	2025-08-05
0002	Restructure as a Monorepo	Accepted	2025-08-25
0003	Centralized Layout Management with CRDT	Proposed	2025-08-27
0004	Fork PrimeVue UI Library	Rejected	2025-08-27
0005	Remove Import Map for Vue Extensions	Accepted	2025-12-13
0006	PrimitiveNode Copy/Paste Lifecycle	Proposed	2026-02-22
0007	NodeExecutionOutput Passthrough Schema	Accepted	2026-03-11

Creating a New ADR

Copy the template below
Name it with the next number in sequence: NNNN-descriptive-title.md
Fill in all sections
Update this index
Submit as part of your PR

ADR Template

# N. Title

Date: YYYY-MM-DD

## Status

[Proposed | Accepted | Rejected | Deprecated | Superseded by [ADR-NNNN](NNNN-title.md)]

## Context

Describe the issue that motivated this decision and any context that influences or constrains the decision.

- What is the problem?
- Why does it need to be solved?
- What forces are at play (technical, business, team)?

## Decision

Describe the decision that was made and the key points that led to it.

- What are we going to do?
- How will we do it?
- What alternatives were considered?

## Consequences

### Positive

- What becomes easier or better?
- What opportunities does this create?

### Negative

- What becomes harder or worse?
- What risks are we accepting?
- What technical debt might we incur?

## Notes

Optional section for additional information, references, or clarifications.

ADR Status Values

Proposed: The decision is being discussed
Accepted: The decision has been agreed upon
Rejected: The decision was not accepted
Deprecated: The decision is no longer relevant
Superseded: The decision has been replaced by another ADR

3.1 KiB Raw Blame History