mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
63 lines
1.6 KiB
TypeScript
63 lines
1.6 KiB
TypeScript
import type { Page } from '@playwright/test'
|
|
|
|
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
import { BaseDialog } from '@e2e/fixtures/components/BaseDialog'
|
|
|
|
export class SettingDialog extends BaseDialog {
|
|
constructor(
|
|
page: Page,
|
|
public readonly comfyPage: ComfyPage
|
|
) {
|
|
super(page, TestIds.dialogs.settings)
|
|
}
|
|
|
|
async open() {
|
|
await this.comfyPage.command.executeCommand('Comfy.ShowSettingsDialog')
|
|
await this.waitForVisible()
|
|
}
|
|
|
|
/**
|
|
* Set the value of a text setting
|
|
* @param id - The id of the setting
|
|
* @param value - The value to set
|
|
*/
|
|
async setStringSetting(id: string, value: string) {
|
|
const settingInputDiv = this.root.locator(`div[id="${id}"]`)
|
|
await settingInputDiv.locator('input').fill(value)
|
|
}
|
|
|
|
/**
|
|
* Toggle the value of a boolean setting
|
|
* @param id - The id of the setting
|
|
*/
|
|
async toggleBooleanSetting(id: string) {
|
|
const settingInputDiv = this.root.locator(`div[id="${id}"]`)
|
|
await settingInputDiv.locator('input').click()
|
|
}
|
|
|
|
get searchBox() {
|
|
return this.root.getByPlaceholder(/Search/)
|
|
}
|
|
|
|
get categories() {
|
|
return this.root.locator('nav').getByRole('button')
|
|
}
|
|
|
|
category(name: string) {
|
|
return this.root.locator('nav').getByRole('button', { name })
|
|
}
|
|
|
|
get contentArea() {
|
|
return this.root.getByRole('main')
|
|
}
|
|
|
|
async goToAboutPanel() {
|
|
const aboutButton = this.root.locator('nav').getByRole('button', {
|
|
name: 'About'
|
|
})
|
|
await aboutButton.click()
|
|
await this.page.waitForSelector('.about-container')
|
|
}
|
|
}
|