mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
79 lines
2.1 KiB
TypeScript
79 lines
2.1 KiB
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
|
|
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
|
|
|
|
export class BuilderSaveAsHelper {
|
|
constructor(private readonly comfyPage: ComfyPage) {}
|
|
|
|
private get page(): Page {
|
|
return this.comfyPage.page
|
|
}
|
|
|
|
/** The save-as dialog (scoped by aria-labelledby). */
|
|
get dialog(): Locator {
|
|
return this.page.locator('[aria-labelledby="builder-save"]')
|
|
}
|
|
|
|
/** The post-save success dialog (scoped by aria-labelledby). */
|
|
get successDialog(): Locator {
|
|
return this.page.locator('[aria-labelledby="builder-save-success"]')
|
|
}
|
|
|
|
get title(): Locator {
|
|
return this.dialog.getByText('Save as')
|
|
}
|
|
|
|
get radioGroup(): Locator {
|
|
return this.dialog.getByRole('radiogroup')
|
|
}
|
|
|
|
get nameInput(): Locator {
|
|
return this.dialog.getByRole('textbox')
|
|
}
|
|
|
|
viewTypeRadio(viewType: 'App' | 'Node graph'): Locator {
|
|
return this.dialog.getByRole('radio', { name: viewType })
|
|
}
|
|
|
|
get saveButton(): Locator {
|
|
return this.dialog.getByRole('button', { name: 'Save' })
|
|
}
|
|
|
|
get successMessage(): Locator {
|
|
return this.successDialog.getByText('Successfully saved')
|
|
}
|
|
|
|
get viewAppButton(): Locator {
|
|
return this.successDialog.getByRole('button', { name: 'View app' })
|
|
}
|
|
|
|
get closeButton(): Locator {
|
|
return this.successDialog
|
|
.getByRole('button', { name: 'Close', exact: true })
|
|
.filter({ hasText: 'Close' })
|
|
}
|
|
|
|
/** The X button to dismiss the success dialog without any action. */
|
|
get dismissButton(): Locator {
|
|
return this.successDialog.locator('button.p-dialog-close-button')
|
|
}
|
|
|
|
get exitBuilderButton(): Locator {
|
|
return this.successDialog.getByRole('button', { name: 'Exit builder' })
|
|
}
|
|
|
|
get overwriteDialog(): Locator {
|
|
return this.page.getByRole('dialog', { name: 'Overwrite existing file?' })
|
|
}
|
|
|
|
get overwriteButton(): Locator {
|
|
return this.overwriteDialog.getByRole('button', { name: 'Overwrite' })
|
|
}
|
|
|
|
async fillAndSave(workflowName: string, viewType: 'App' | 'Node graph') {
|
|
await this.nameInput.fill(workflowName)
|
|
await this.viewTypeRadio(viewType).click()
|
|
await this.saveButton.click()
|
|
}
|
|
}
|