mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
66 lines
2.0 KiB
TypeScript
66 lines
2.0 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Focus Mode', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
test('Focus mode hides UI chrome', async ({ comfyPage }) => {
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
|
|
await comfyPage.setFocusMode(true)
|
|
|
|
await expect(comfyPage.menu.sideToolbar).not.toBeVisible()
|
|
})
|
|
|
|
test('Focus mode restores UI chrome', async ({ comfyPage }) => {
|
|
await comfyPage.setFocusMode(true)
|
|
await expect(comfyPage.menu.sideToolbar).not.toBeVisible()
|
|
|
|
await comfyPage.setFocusMode(false)
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
})
|
|
|
|
test('Toggle focus mode command works', async ({ comfyPage }) => {
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
|
|
await comfyPage.command.executeCommand('Workspace.ToggleFocusMode')
|
|
await comfyPage.nextFrame()
|
|
await expect(comfyPage.menu.sideToolbar).not.toBeVisible()
|
|
|
|
await comfyPage.command.executeCommand('Workspace.ToggleFocusMode')
|
|
await comfyPage.nextFrame()
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
})
|
|
|
|
test('Focus mode hides topbar', async ({ comfyPage }) => {
|
|
const topMenu = comfyPage.page.locator('.comfy-menu-button-wrapper')
|
|
await expect(topMenu).toBeVisible()
|
|
|
|
await comfyPage.setFocusMode(true)
|
|
|
|
await expect(topMenu).not.toBeVisible()
|
|
})
|
|
|
|
test('Canvas remains visible in focus mode', async ({ comfyPage }) => {
|
|
await comfyPage.setFocusMode(true)
|
|
|
|
await expect(comfyPage.canvas).toBeVisible()
|
|
})
|
|
|
|
test('Focus mode can be toggled multiple times', async ({ comfyPage }) => {
|
|
await comfyPage.setFocusMode(true)
|
|
await expect(comfyPage.menu.sideToolbar).not.toBeVisible()
|
|
|
|
await comfyPage.setFocusMode(false)
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
|
|
await comfyPage.setFocusMode(true)
|
|
await expect(comfyPage.menu.sideToolbar).not.toBeVisible()
|
|
})
|
|
})
|