mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
59 lines
2.1 KiB
TypeScript
59 lines
2.1 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe(
|
|
'Image paste priority over stale node metadata',
|
|
{ tag: ['@node'] },
|
|
() => {
|
|
test('Should not paste copied node when a LoadImage node is selected and clipboard has stale node metadata', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.workflow.loadWorkflow('nodes/load_image_with_ksampler')
|
|
|
|
const initialCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
expect(initialCount).toBe(2)
|
|
|
|
// Copy the KSampler node (puts data-metadata in clipboard)
|
|
const ksamplerNodes =
|
|
await comfyPage.nodeOps.getNodeRefsByType('KSampler')
|
|
await ksamplerNodes[0].copy()
|
|
|
|
// Select the LoadImage node
|
|
const loadImageNodes =
|
|
await comfyPage.nodeOps.getNodeRefsByType('LoadImage')
|
|
await loadImageNodes[0].click('title')
|
|
|
|
// Simulate pasting when clipboard has stale node metadata (text/html
|
|
// with data-metadata) but no image file items. This replicates the bug
|
|
// scenario: user copied a node, then copied a web image (which replaces
|
|
// clipboard files but may leave stale text/html with node metadata).
|
|
await comfyPage.page.evaluate(() => {
|
|
const nodeData = { nodes: [{ type: 'KSampler', id: 99 }] }
|
|
const base64 = btoa(JSON.stringify(nodeData))
|
|
const html =
|
|
'<meta charset="utf-8"><div><span data-metadata="' +
|
|
base64 +
|
|
'"></span></div><span style="white-space:pre-wrap;">Text</span>'
|
|
|
|
const dataTransfer = new DataTransfer()
|
|
dataTransfer.setData('text/html', html)
|
|
|
|
const event = new ClipboardEvent('paste', {
|
|
clipboardData: dataTransfer,
|
|
bubbles: true,
|
|
cancelable: true
|
|
})
|
|
document.dispatchEvent(event)
|
|
})
|
|
|
|
await comfyPage.nextFrame()
|
|
|
|
// Node count should remain the same — stale node metadata should NOT
|
|
// be deserialized when a media node is selected.
|
|
const finalCount = await comfyPage.nodeOps.getGraphNodesCount()
|
|
expect(finalCount).toBe(initialCount)
|
|
})
|
|
}
|
|
)
|