mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-07-11 01:28:03 +00:00
## Summary Narrow Knip's Playwright `entry` to actual spec files so dead exports in browser-test fixtures are reported instead of being hidden by treating every helper as an entrypoint. ## Changes - **What**: - `knip.config.ts`: Playwright `entry` changed from the broad `['**/*.@(spec|test)…', 'browser_tests/**/*.ts']` to `['browser_tests/**/*.@(spec|test).?(c|m)[jt]s?(x)']`. `globalSetup`/`globalTeardown` stay covered via Knip's playwright config resolution; fixtures remain in the project graph so their unused exports surface. - Resolved the 54 dead findings this exposed: over-exported symbols used only within their own module are now module-private (dropped `export`, no behavioral change); genuinely unreferenced fixtures were deleted (asset/template `ALL_*` aggregators + orphaned `STABLE_*` data, `TemplateHelper` distribution helpers + `generateTemplates`, dead types/utils, and the unused `nodeDefinitions.ts` module). - **Breaking**: none — test-only changes. ## Review Focus - Deletions are limited to fixtures with zero importers on `main` (verified via `pnpm knip`); the bulk of the diff is `export`-keyword removal. - Verified: `pnpm knip` (browser_tests clean), `pnpm typecheck`, `pnpm typecheck:browser`, oxfmt/oxlint/eslint all pass. Linear: FE-717
34 lines
1023 B
TypeScript
34 lines
1023 B
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
import { test as base } from '@playwright/test'
|
|
|
|
class UserSelectPage {
|
|
public readonly selectionUrl: string
|
|
public readonly container: Locator
|
|
public readonly newUserInput: Locator
|
|
public readonly existingUserSelect: Locator
|
|
public readonly nextButton: Locator
|
|
|
|
constructor(
|
|
public readonly url: string,
|
|
public readonly page: Page
|
|
) {
|
|
this.selectionUrl = url + '/user-select'
|
|
this.container = page.locator('#comfy-user-selection')
|
|
this.newUserInput = this.container.locator('#new-user-input')
|
|
this.existingUserSelect = this.container.locator('#existing-user-select')
|
|
this.nextButton = this.container.getByText('Next')
|
|
}
|
|
}
|
|
|
|
export const userSelectPageFixture = base.extend<{
|
|
userSelectPage: UserSelectPage
|
|
}>({
|
|
userSelectPage: async ({ page }, use) => {
|
|
const userSelectPage = new UserSelectPage(
|
|
process.env.PLAYWRIGHT_TEST_URL || 'http://localhost:8188',
|
|
page
|
|
)
|
|
await use(userSelectPage)
|
|
}
|
|
})
|