mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-01 05:49:54 +00:00
82bacb82a7
## Summary
Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.
## Tags Added
| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |
## Usage Examples
```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke
# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow
# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot
# Run only canvas-related tests
pnpm test:browser -- --grep @canvas
# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```
## Implementation Details
- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`
## Test Plan
- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
62 lines
2.5 KiB
TypeScript
62 lines
2.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
import type { NodeReference } from '../fixtures/utils/litegraphUtils'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Primitive Node', { tag: ['@screenshot', '@node'] }, () => {
|
|
test('Can load with correct size', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('primitive/primitive_node')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('primitive_node.png')
|
|
})
|
|
|
|
// When link is dropped on widget, it should automatically convert the widget
|
|
// to input.
|
|
test('Can connect to widget', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('primitive/primitive_node_unconnected')
|
|
const primitiveNode: NodeReference = await comfyPage.getNodeRefById(1)
|
|
const ksamplerNode: NodeReference = await comfyPage.getNodeRefById(2)
|
|
// Connect the output of the primitive node to the input of first widget of the ksampler node
|
|
await primitiveNode.connectWidget(0, ksamplerNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'primitive_node_connected.png'
|
|
)
|
|
})
|
|
|
|
test('Can connect to dom widget', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow(
|
|
'primitive/primitive_node_unconnected_dom_widget'
|
|
)
|
|
const primitiveNode: NodeReference = await comfyPage.getNodeRefById(1)
|
|
const clipEncoderNode: NodeReference = await comfyPage.getNodeRefById(2)
|
|
await primitiveNode.connectWidget(0, clipEncoderNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'primitive_node_connected_dom_widget.png'
|
|
)
|
|
})
|
|
|
|
test('Can connect to static primitive node', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('primitive/static_primitive_unconnected')
|
|
const primitiveNode: NodeReference = await comfyPage.getNodeRefById(1)
|
|
const ksamplerNode: NodeReference = await comfyPage.getNodeRefById(2)
|
|
await primitiveNode.connectWidget(0, ksamplerNode, 0)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'static_primitive_connected.png'
|
|
)
|
|
})
|
|
|
|
test('Report missing nodes when connect to missing node', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.loadWorkflow(
|
|
'primitive/primitive_node_connect_missing_node'
|
|
)
|
|
// Wait for the element with the .comfy-missing-nodes selector to be visible
|
|
const missingNodesWarning = comfyPage.page.locator('.comfy-missing-nodes')
|
|
await expect(missingNodesWarning).toBeVisible()
|
|
})
|
|
})
|