mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-01 13:59:54 +00:00
## Summary
Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.
## Tags Added
| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |
## Usage Examples
```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke
# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow
# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot
# Run only canvas-related tests
pnpm test:browser -- --grep @canvas
# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```
## Implementation Details
- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`
## Test Plan
- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
157 lines
5.2 KiB
TypeScript
157 lines
5.2 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
import type { ComfyPage } from '../fixtures/ComfyPage'
|
|
|
|
test.describe('Workflow Tab Thumbnails', { tag: '@workflow' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.setSetting('Comfy.Workflow.WorkflowTabsPosition', 'Topbar')
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
async function getTab(comfyPage: ComfyPage, index: number) {
|
|
const tab = comfyPage.page
|
|
.locator(`.workflow-tabs .p-togglebutton`)
|
|
.nth(index)
|
|
return tab
|
|
}
|
|
|
|
async function getTabPopover(
|
|
comfyPage: ComfyPage,
|
|
index: number,
|
|
name?: string
|
|
) {
|
|
const tab = await getTab(comfyPage, index)
|
|
await tab.hover()
|
|
|
|
const popover = comfyPage.page.locator('.workflow-popover-fade')
|
|
await expect(popover).toHaveCount(1)
|
|
await expect(popover).toBeVisible({ timeout: 500 })
|
|
if (name) {
|
|
await expect(popover).toContainText(name)
|
|
}
|
|
return popover
|
|
}
|
|
|
|
async function getTabThumbnailImage(
|
|
comfyPage: ComfyPage,
|
|
index: number,
|
|
name?: string
|
|
) {
|
|
const popover = await getTabPopover(comfyPage, index, name)
|
|
const thumbnailImg = popover.locator('.workflow-preview-thumbnail img')
|
|
return thumbnailImg
|
|
}
|
|
|
|
async function getNodeThumbnailBase64(comfyPage: ComfyPage, index: number) {
|
|
const thumbnailImg = await getTabThumbnailImage(comfyPage, index)
|
|
const src = (await thumbnailImg.getAttribute('src'))!
|
|
|
|
// Convert blob to base64, need to execute a script to get the base64
|
|
const base64 = await comfyPage.page.evaluate(async (src: string) => {
|
|
const blob = await fetch(src).then((res) => res.blob())
|
|
return new Promise((resolve, reject) => {
|
|
const reader = new FileReader()
|
|
reader.onloadend = () => resolve(reader.result)
|
|
reader.onerror = reject
|
|
reader.readAsDataURL(blob)
|
|
})
|
|
}, src)
|
|
return base64
|
|
}
|
|
|
|
test('Should show thumbnail when hovering over a non-active tab', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.menu.topbar.triggerTopbarCommand(['New'])
|
|
const thumbnailImg = await getTabThumbnailImage(
|
|
comfyPage,
|
|
0,
|
|
'Unsaved Workflow'
|
|
)
|
|
await expect(thumbnailImg).toBeVisible()
|
|
})
|
|
|
|
test('Should not show thumbnail for active tab', async ({ comfyPage }) => {
|
|
await comfyPage.menu.topbar.triggerTopbarCommand(['New'])
|
|
const thumbnailImg = await getTabThumbnailImage(
|
|
comfyPage,
|
|
1,
|
|
'Unsaved Workflow (2)'
|
|
)
|
|
await expect(thumbnailImg).not.toBeVisible()
|
|
})
|
|
|
|
async function addNode(comfyPage: ComfyPage, category: string, node: string) {
|
|
const canvasArea = await comfyPage.canvas.boundingBox()
|
|
|
|
await comfyPage.page.mouse.move(
|
|
canvasArea!.x + canvasArea!.width - 100,
|
|
100
|
|
)
|
|
await comfyPage.delay(300) // Wait for the popover to hide
|
|
|
|
await comfyPage.rightClickCanvas(200, 200)
|
|
await comfyPage.page.getByText('Add Node').click()
|
|
await comfyPage.nextFrame()
|
|
await comfyPage.page.getByText(category).click()
|
|
await comfyPage.nextFrame()
|
|
await comfyPage.page.getByText(node).click()
|
|
await comfyPage.nextFrame()
|
|
}
|
|
|
|
test('Thumbnail should update when switching tabs', async ({ comfyPage }) => {
|
|
// Wait for initial workflow to load
|
|
await comfyPage.nextFrame()
|
|
|
|
// Create a new workflow (tab 1) which will be empty
|
|
await comfyPage.menu.topbar.triggerTopbarCommand(['New'])
|
|
await comfyPage.nextFrame()
|
|
|
|
// Now we have two tabs: tab 0 (default workflow with nodes) and tab 1 (empty)
|
|
// Tab 1 is currently active, so we can only get thumbnail for tab 0
|
|
|
|
// Step 1: Different tabs should show different previews
|
|
const tab0ThumbnailWithNodes = await getNodeThumbnailBase64(comfyPage, 0)
|
|
|
|
// Add a node to tab 1 (current active tab)
|
|
await addNode(comfyPage, 'loaders', 'Load Checkpoint')
|
|
await comfyPage.nextFrame()
|
|
|
|
// Switch to tab 0 so we can get tab 1's thumbnail
|
|
await (await getTab(comfyPage, 0)).click()
|
|
await comfyPage.nextFrame()
|
|
|
|
const tab1ThumbnailWithNode = await getNodeThumbnailBase64(comfyPage, 1)
|
|
|
|
// The thumbnails should be different
|
|
expect(tab0ThumbnailWithNodes).not.toBe(tab1ThumbnailWithNode)
|
|
|
|
// Step 2: Switching without changes shouldn't update thumbnail
|
|
const tab1ThumbnailBefore = await getNodeThumbnailBase64(comfyPage, 1)
|
|
|
|
// Switch to tab 1 and back to tab 0 without making changes
|
|
await (await getTab(comfyPage, 1)).click()
|
|
await comfyPage.nextFrame()
|
|
await (await getTab(comfyPage, 0)).click()
|
|
await comfyPage.nextFrame()
|
|
|
|
const tab1ThumbnailAfter = await getNodeThumbnailBase64(comfyPage, 1)
|
|
expect(tab1ThumbnailBefore).toBe(tab1ThumbnailAfter)
|
|
|
|
// Step 3: Adding another node should cause thumbnail to change
|
|
// We're on tab 0, add a node
|
|
await addNode(comfyPage, 'loaders', 'Load VAE')
|
|
await comfyPage.nextFrame()
|
|
|
|
// Switch to tab 1 and back to update tab 0's thumbnail
|
|
await (await getTab(comfyPage, 1)).click()
|
|
|
|
const tab0ThumbnailAfterNewNode = await getNodeThumbnailBase64(comfyPage, 0)
|
|
|
|
// The thumbnail should have changed after adding a node
|
|
expect(tab0ThumbnailWithNodes).not.toBe(tab0ThumbnailAfterNewNode)
|
|
})
|
|
})
|