mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-04 07:00:23 +00:00

Files

Christian Byrne c2eb4f03e9 fix: onNodeRemoved not called when loading new graph (and tearing down previous) (#5407 )

* standardize graph cleanup

* test: fix useCoreCommands tests and add regression test

- Fix mocking to properly simulate app.clean() calling graph.clear()
- Add intelligent subgraph detection in mock to match real implementation
- Add regression test for Vue node cleanup bug to prevent future regressions
- Ensures app.clean() properly triggers onNodeRemoved events through graph.clear()

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix unit tests

* move beforeLoadNewGraph to before graph is cleaned

---------

Co-authored-by: Claude <noreply@anthropic.com>

2025-09-06 19:35:57 -07:00

canvas

[refactor] Migrate litegraph tests to centralized location (#5072 )

2025-08-18 10:28:31 -07:00

core

fix: onNodeRemoved not called when loading new graph (and tearing down previous) (#5407 )

2025-09-06 19:35:57 -07:00

infrastructure

[refactor] Migrate litegraph tests to centralized location (#5072 )

2025-08-18 10:28:31 -07:00

subgraph

knip: YOLO pass, all the unused exports enabled, YAGNI for the rest (#5313 )

2025-09-04 22:29:44 -07:00

utils

[refactor] Migrate litegraph tests to centralized location (#5072 )

2025-08-18 10:28:31 -07:00

README.md

Migration: pnpm (#5215 )

2025-08-27 06:10:15 -07:00

README.md

LiteGraph Tests

This directory contains the test suite for the LiteGraph library.

Structure

litegraph/
├── core/           # Core functionality tests (LGraph, LGraphNode, etc.)
├── canvas/         # Canvas-related tests (rendering, interactions)
├── infrastructure/ # Infrastructure tests (Rectangle, utilities)
├── subgraph/       # Subgraph-specific tests
├── utils/          # Utility function tests
└── fixtures/       # Test helpers, fixtures, and assets

Running Tests

# Run all litegraph tests
pnpm test:unit -- tests-ui/tests/litegraph/

# Run specific subdirectory
pnpm test:unit -- tests-ui/tests/litegraph/core/

# Run single test file
pnpm test:unit -- tests-ui/tests/litegraph/core/LGraph.test.ts

Migration Status

These tests were migrated from src/lib/litegraph/test/ to centralize test infrastructure. Currently, some tests are marked with .skip due to import/setup issues that need to be resolved.

TODO: Fix Skipped Tests

The following test files have been temporarily disabled and need fixes:

Most subgraph tests (circular dependency issues)
Some core tests (missing test utilities)
Canvas tests (mock setup issues)

See individual test files marked with // TODO: Fix these tests after migration for specific issues.

Writing New Tests

Always import from the barrel export to avoid circular dependencies:

import { LGraph, LGraphNode } from '@/lib/litegraph/src/litegraph'

Use the test fixtures from fixtures/ directory
Follow existing patterns for test organization

Test Fixtures

Test fixtures and helpers are located in the fixtures/ directory:

testExtensions.ts - Custom vitest extensions
subgraphHelpers.ts - Helpers for creating test subgraphs
subgraphFixtures.ts - Common subgraph test scenarios
assets/ - Test data files