mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-05 07:30:11 +00:00
f2d5bfab73
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
52 lines
1.6 KiB
TypeScript
52 lines
1.6 KiB
TypeScript
import type { Position } from './types'
|
|
|
|
/**
|
|
* Hardcoded positions for the default graph loaded in tests.
|
|
* These coordinates are specific to the default workflow viewport.
|
|
*/
|
|
export const DefaultGraphPositions = {
|
|
// Node click positions
|
|
textEncodeNode1: { x: 618, y: 191 },
|
|
textEncodeNode2: { x: 622, y: 400 },
|
|
textEncodeNodeToggler: { x: 430, y: 171 },
|
|
emptySpaceClick: { x: 35, y: 31 },
|
|
|
|
// Slot positions
|
|
clipTextEncodeNode1InputSlot: { x: 427, y: 198 },
|
|
clipTextEncodeNode2InputSlot: { x: 422, y: 402 },
|
|
clipTextEncodeNode2InputLinkPath: { x: 395, y: 422 },
|
|
loadCheckpointNodeClipOutputSlot: { x: 332, y: 509 },
|
|
emptySpace: { x: 427, y: 98 },
|
|
|
|
// Widget positions
|
|
emptyLatentWidgetClick: { x: 724, y: 645 },
|
|
|
|
// Node positions and sizes for resize operations
|
|
ksampler: {
|
|
pos: { x: 863, y: 156 },
|
|
size: { width: 315, height: 292 }
|
|
},
|
|
loadCheckpoint: {
|
|
pos: { x: 26, y: 444 },
|
|
size: { width: 315, height: 127 }
|
|
},
|
|
emptyLatent: {
|
|
pos: { x: 473, y: 579 },
|
|
size: { width: 315, height: 136 }
|
|
}
|
|
} as const satisfies {
|
|
textEncodeNode1: Position
|
|
textEncodeNode2: Position
|
|
textEncodeNodeToggler: Position
|
|
emptySpaceClick: Position
|
|
clipTextEncodeNode1InputSlot: Position
|
|
clipTextEncodeNode2InputSlot: Position
|
|
clipTextEncodeNode2InputLinkPath: Position
|
|
loadCheckpointNodeClipOutputSlot: Position
|
|
emptySpace: Position
|
|
emptyLatentWidgetClick: Position
|
|
ksampler: { pos: Position; size: { width: number; height: number } }
|
|
loadCheckpoint: { pos: Position; size: { width: number; height: number } }
|
|
emptyLatent: { pos: Position; size: { width: number; height: number } }
|
|
}
|