mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
0132c77c7d
## Summary
Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI
runs by replacing race-prone patterns with retry-safe alternatives.
No source code changes -- only `browser_tests/` is touched.
## Changes
- **E2E spec hardening** (98 spec files, 6 fixtures, 2 helpers):
| Fix class | Sites | Examples |
|-----------|-------|---------:|
| `expect(await ...)` -> `expect.poll()` | ~153 | interaction,
defaultKeybindings, workflows, featureFlags |
| `const x = await loc.count(); expect(x)` -> `toHaveCount()` | ~19 |
menu, linkInteraction, assets, bottomPanelShortcuts |
| `nextFrame()` -> `waitForHidden()` after menu clicks | ~22 |
contextMenu, rightClickMenu, subgraphHelper |
| Redundant `nextFrame()` removed | many | defaultKeybindings, minimap,
builderSaveFlow |
| `expect(async () => { ... }).toPass()` retry blocks | 5 | interaction
(graphdialog dismiss guard) |
| `force:true` removed from `BaseDialog.close()` | 1 | BaseDialog
fixture |
| ContextMenu `waitForHidden` simplified (check-then-act race removed) |
1 | ContextMenu fixture |
| Non-deterministic node order -> proximity-based selection | 1 |
interaction (toggle dom widget) |
| Tight poll timeout (250ms) -> >=2000ms | 2 | templates |
- **Helper improvements**: Exposed locator getters on
`ComfyPage.domWidgets`, `ToastHelper.toastErrors`, and
`WorkflowsSidebarTab.activeWorkflowLabel` so callers can use retrying
assertions (`toHaveCount()`, `toHaveText()`) directly.
- **Flake pattern catalog**: Added section 7 table to
`browser_tests/FLAKE_PREVENTION_RULES.md` documenting 8 pattern classes
for reviewers and future authors.
- **Docs**: Fixed bad examples in `browser_tests/README.md` to use
`expect.poll()`.
- **Breaking**: None
- **Dependencies**: None
## Review Focus
- All fixes follow the rules in
`browser_tests/FLAKE_PREVENTION_RULES.md`
- No behavioral changes to tests -- only timing/retry strategy is
updated
- The `ContextMenu.waitForHidden` simplification removes a
swallowed-error anti-pattern; both locators now use direct `waitFor({
state: 'hidden' })`
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>
95 lines
3.0 KiB
TypeScript
95 lines
3.0 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
test.describe('Properties panel position', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.NodeLibrary.NewDesign', false)
|
|
// Open a sidebar tab to ensure sidebar is visible
|
|
await comfyPage.menu.nodeLibraryTab.open()
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
})
|
|
|
|
test('positions on the right when sidebar is on the left', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'left')
|
|
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
const sidebar = comfyPage.page.locator('.side-bar-panel').first()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
await expect(sidebar).toBeVisible()
|
|
|
|
await expect
|
|
.poll(async () => {
|
|
const propsBoundingBox = await propertiesPanel.boundingBox()
|
|
const sidebarBoundingBox = await sidebar.boundingBox()
|
|
|
|
if (!propsBoundingBox || !sidebarBoundingBox) return false
|
|
|
|
return (
|
|
propsBoundingBox.x > sidebarBoundingBox.x + sidebarBoundingBox.width
|
|
)
|
|
})
|
|
.toBe(true)
|
|
})
|
|
|
|
test('positions on the left when sidebar is on the right', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'right')
|
|
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
const sidebar = comfyPage.page.locator('.side-bar-panel').first()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
await expect(sidebar).toBeVisible()
|
|
|
|
await expect
|
|
.poll(async () => {
|
|
const propsBoundingBox = await propertiesPanel.boundingBox()
|
|
const sidebarBoundingBox = await sidebar.boundingBox()
|
|
|
|
if (!propsBoundingBox || !sidebarBoundingBox) return false
|
|
|
|
return (
|
|
propsBoundingBox.x + propsBoundingBox.width < sidebarBoundingBox.x
|
|
)
|
|
})
|
|
.toBe(true)
|
|
})
|
|
|
|
test('close button icon updates based on sidebar location', async ({
|
|
comfyPage
|
|
}) => {
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
|
|
// When sidebar is on the left, panel is on the right
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'left')
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
const closeButtonLeft = propertiesPanel
|
|
.locator('button[aria-pressed]')
|
|
.locator('i')
|
|
await expect(closeButtonLeft).toBeVisible()
|
|
await expect(closeButtonLeft).toHaveClass(/lucide--panel-right/)
|
|
|
|
// When sidebar is on the right, panel is on the left
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'right')
|
|
|
|
const closeButtonRight = propertiesPanel
|
|
.locator('button[aria-pressed]')
|
|
.locator('i')
|
|
await expect(closeButtonRight).toBeVisible()
|
|
await expect(closeButtonRight).toHaveClass(/lucide--panel-left/)
|
|
})
|
|
})
|