mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
127 lines
3.6 KiB
TypeScript
127 lines
3.6 KiB
TypeScript
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Queue Clear History Dialog', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setup()
|
|
await comfyPage.queuePanel.overlayToggle.click()
|
|
})
|
|
|
|
test('Dialog opens from queue panel history actions menu', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
})
|
|
|
|
test('Dialog shows confirmation message with title, description, and assets note', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
|
|
await expect(
|
|
dialog.getByText('Clear your job queue history?')
|
|
).toBeVisible()
|
|
|
|
await expect(
|
|
dialog.getByText(
|
|
'All the finished or failed jobs below will be removed from this Job queue panel.'
|
|
)
|
|
).toBeVisible()
|
|
|
|
await expect(
|
|
dialog.getByText(
|
|
'Assets generated by these jobs won\u2019t be deleted and can always be viewed from the assets panel.'
|
|
)
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Cancel button closes dialog without clearing history', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
|
|
let clearCalled = false
|
|
await comfyPage.page.route('**/api/history', (route) => {
|
|
if (route.request().method() === 'POST') {
|
|
clearCalled = true
|
|
}
|
|
return route.continue()
|
|
})
|
|
|
|
await dialog.getByRole('button', { name: 'Cancel' }).click()
|
|
await expect(dialog).not.toBeVisible()
|
|
expect(clearCalled).toBe(false)
|
|
|
|
await comfyPage.page.unroute('**/api/history')
|
|
})
|
|
|
|
test('Close (X) button closes dialog without clearing history', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
|
|
let clearCalled = false
|
|
await comfyPage.page.route('**/api/history', (route) => {
|
|
if (route.request().method() === 'POST') {
|
|
clearCalled = true
|
|
}
|
|
return route.continue()
|
|
})
|
|
|
|
await dialog.getByLabel('Close').click()
|
|
await expect(dialog).not.toBeVisible()
|
|
expect(clearCalled).toBe(false)
|
|
|
|
await comfyPage.page.unroute('**/api/history')
|
|
})
|
|
|
|
test('Confirm clears queue history and closes dialog', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
|
|
const clearPromise = comfyPage.page.waitForRequest(
|
|
(req) => req.url().includes('/api/history') && req.method() === 'POST'
|
|
)
|
|
|
|
await dialog.getByRole('button', { name: 'Clear' }).click()
|
|
|
|
const request = await clearPromise
|
|
expect(request.postDataJSON()).toEqual({ clear: true })
|
|
|
|
await expect(dialog).not.toBeVisible()
|
|
})
|
|
|
|
test('Dialog state resets after close and reopen', async ({ comfyPage }) => {
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
const dialog = comfyPage.confirmDialog.root
|
|
await expect(dialog).toBeVisible()
|
|
await dialog.getByRole('button', { name: 'Cancel' }).click()
|
|
await expect(dialog).not.toBeVisible()
|
|
|
|
await comfyPage.queuePanel.openClearHistoryDialog()
|
|
await expect(dialog).toBeVisible()
|
|
|
|
const clearButton = dialog.getByRole('button', { name: 'Clear' })
|
|
await expect(clearButton).toBeVisible()
|
|
await expect(clearButton).toBeEnabled()
|
|
})
|
|
})
|