mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
*PR Created by the Glary-Bot Agent* --- ## Summary - Replace all `as unknown as Type` assertions in 59 unit test files with type-safe `@total-typescript/shoehorn` functions - Use `fromPartial<Type>()` for partial mock objects where deep-partial type-checks (21 files) - Use `fromAny<Type>()` for fundamentally incompatible types: null, undefined, primitives, variables, class expressions, and mocks with test-specific extra properties that `PartialDeepObject` rejects (remaining files) - All explicit type parameters preserved so TypeScript return types are correct - Browser test `.spec.ts` files excluded (shoehorn unavailable in `page.evaluate` browser context) ## Verification - `pnpm typecheck` ✅ - `pnpm lint` ✅ - `pnpm format` ✅ - Pre-commit hooks passed (format + oxlint + eslint + typecheck) - Migrated test files verified passing (ran representative subset) - No test behavior changes — only type assertion syntax changed - No UI changes — screenshots not applicable ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10761-test-migrate-as-unknown-as-to-total-typescript-shoehorn-3336d73d365081f6b8adc44db5dcc380) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
133 lines
3.9 KiB
TypeScript
133 lines
3.9 KiB
TypeScript
import { fromAny } from '@total-typescript/shoehorn'
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { useCreateWorkspaceUrlLoader } from './useCreateWorkspaceUrlLoader'
|
|
|
|
const preservedQueryMocks = vi.hoisted(() => ({
|
|
clearPreservedQuery: vi.fn(),
|
|
hydratePreservedQuery: vi.fn(),
|
|
mergePreservedQueryIntoQuery: vi.fn()
|
|
}))
|
|
|
|
vi.mock(
|
|
'@/platform/navigation/preservedQueryManager',
|
|
() => preservedQueryMocks
|
|
)
|
|
|
|
const mockRouteQuery = vi.hoisted(() => ({
|
|
value: {} as Record<string, string>
|
|
}))
|
|
const mockRouterReplace = vi.hoisted(() => vi.fn().mockResolvedValue(undefined))
|
|
|
|
vi.mock('vue-router', () => ({
|
|
useRoute: () => ({
|
|
query: mockRouteQuery.value
|
|
}),
|
|
useRouter: () => ({
|
|
replace: mockRouterReplace
|
|
})
|
|
}))
|
|
|
|
const mockShowTeamWorkspacesDialog = vi.hoisted(() =>
|
|
vi.fn().mockResolvedValue(undefined)
|
|
)
|
|
|
|
vi.mock('@/services/dialogService', () => ({
|
|
useDialogService: () => ({
|
|
showTeamWorkspacesDialog: mockShowTeamWorkspacesDialog
|
|
})
|
|
}))
|
|
|
|
describe('useCreateWorkspaceUrlLoader', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockRouteQuery.value = {}
|
|
preservedQueryMocks.mergePreservedQueryIntoQuery.mockReturnValue(null)
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks()
|
|
})
|
|
|
|
describe('loadCreateWorkspaceFromUrl', () => {
|
|
it('does nothing when no create_workspace param present', async () => {
|
|
mockRouteQuery.value = {}
|
|
|
|
const { loadCreateWorkspaceFromUrl } = useCreateWorkspaceUrlLoader()
|
|
await loadCreateWorkspaceFromUrl()
|
|
|
|
expect(mockShowTeamWorkspacesDialog).not.toHaveBeenCalled()
|
|
expect(mockRouterReplace).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('opens create workspace dialog when param is present', async () => {
|
|
mockRouteQuery.value = { create_workspace: '1' }
|
|
|
|
const { loadCreateWorkspaceFromUrl } = useCreateWorkspaceUrlLoader()
|
|
await loadCreateWorkspaceFromUrl()
|
|
|
|
expect(mockShowTeamWorkspacesDialog).toHaveBeenCalledOnce()
|
|
})
|
|
|
|
it('restores preserved query and opens dialog', async () => {
|
|
mockRouteQuery.value = {}
|
|
preservedQueryMocks.mergePreservedQueryIntoQuery.mockReturnValue({
|
|
create_workspace: '1'
|
|
})
|
|
|
|
const { loadCreateWorkspaceFromUrl } = useCreateWorkspaceUrlLoader()
|
|
await loadCreateWorkspaceFromUrl()
|
|
|
|
expect(preservedQueryMocks.hydratePreservedQuery).toHaveBeenCalledWith(
|
|
'create_workspace'
|
|
)
|
|
expect(mockRouterReplace).toHaveBeenCalledWith({
|
|
query: { create_workspace: '1' }
|
|
})
|
|
expect(mockShowTeamWorkspacesDialog).toHaveBeenCalledOnce()
|
|
})
|
|
|
|
it('cleans up URL after processing', async () => {
|
|
mockRouteQuery.value = { create_workspace: '1', other: 'param' }
|
|
|
|
const { loadCreateWorkspaceFromUrl } = useCreateWorkspaceUrlLoader()
|
|
await loadCreateWorkspaceFromUrl()
|
|
|
|
expect(mockRouterReplace).toHaveBeenCalledWith({
|
|
query: { other: 'param' }
|
|
})
|
|
})
|
|
|
|
it('clears preserved query after processing', async () => {
|
|
mockRouteQuery.value = { create_workspace: '1' }
|
|
|
|
const { loadCreateWorkspaceFromUrl } = useCreateWorkspaceUrlLoader()
|
|
await loadCreateWorkspaceFromUrl()
|
|
|
|
expect(preservedQueryMocks.clearPreservedQuery).toHaveBeenCalledWith(
|
|
'create_workspace'
|
|
)
|
|
})
|
|
|
|
it('ignores empty param', async () => {
|
|
mockRouteQuery.value = { create_workspace: '' }
|
|
|
|
const { loadCreateWorkspaceFromUrl } = useCreateWorkspaceUrlLoader()
|
|
await loadCreateWorkspaceFromUrl()
|
|
|
|
expect(mockShowTeamWorkspacesDialog).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('ignores non-string param', async () => {
|
|
mockRouteQuery.value = {
|
|
create_workspace: fromAny<string, unknown>(['array'])
|
|
}
|
|
|
|
const { loadCreateWorkspaceFromUrl } = useCreateWorkspaceUrlLoader()
|
|
await loadCreateWorkspaceFromUrl()
|
|
|
|
expect(mockShowTeamWorkspacesDialog).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
})
|