mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
84 lines
2.9 KiB
TypeScript
84 lines
2.9 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
const PIN_HOTKEY = 'p'
|
|
const PIN_INDICATOR = '[data-testid="node-pin-indicator"]'
|
|
|
|
test.describe('Vue Node Pin', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('should allow toggling pin on a selected node with hotkey', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
|
|
const pinIndicator = checkpointNode.locator(PIN_INDICATOR)
|
|
|
|
await expect(pinIndicator).toBeVisible()
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
await expect(pinIndicator).toBeHidden()
|
|
})
|
|
|
|
test('should allow toggling pin on multiple selected nodes with hotkey', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.page.getByText('KSampler').click({ modifiers: ['Control'] })
|
|
|
|
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
|
|
const ksamplerNode = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
const pinIndicator1 = checkpointNode.locator(PIN_INDICATOR)
|
|
await expect(pinIndicator1).toBeVisible()
|
|
const pinIndicator2 = ksamplerNode.locator(PIN_INDICATOR)
|
|
await expect(pinIndicator2).toBeVisible()
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
await expect(pinIndicator1).toBeHidden()
|
|
await expect(pinIndicator2).toBeHidden()
|
|
})
|
|
|
|
test('should not allow dragging pinned nodes', async ({ comfyPage }) => {
|
|
const checkpointNodeHeader = comfyPage.page.getByText('Load Checkpoint')
|
|
await checkpointNodeHeader.click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
// Try to drag the node
|
|
const headerPos = await checkpointNodeHeader.boundingBox()
|
|
if (!headerPos) throw new Error('Failed to get header position')
|
|
await comfyPage.canvasOps.dragAndDrop(
|
|
{ x: headerPos.x, y: headerPos.y },
|
|
{ x: headerPos.x + 256, y: headerPos.y + 256 }
|
|
)
|
|
|
|
// Verify the node is not dragged (same position before and after click-and-drag)
|
|
await expect
|
|
.poll(async () => await checkpointNodeHeader.boundingBox())
|
|
.toEqual(headerPos)
|
|
|
|
// Unpin the node with the hotkey
|
|
await checkpointNodeHeader.click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
// Try to drag the node again
|
|
await comfyPage.canvasOps.dragAndDrop(
|
|
{ x: headerPos.x, y: headerPos.y },
|
|
{ x: headerPos.x + 256, y: headerPos.y + 256 }
|
|
)
|
|
|
|
// Verify the node is dragged
|
|
await expect
|
|
.poll(async () => await checkpointNodeHeader.boundingBox())
|
|
.not.toEqual(headerPos)
|
|
})
|
|
})
|