mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
61 lines
2.1 KiB
TypeScript
61 lines
2.1 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
import type { TestGraphAccess } from '@e2e/types/globals'
|
|
|
|
test.describe('Vue Widget Reactivity', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('Should display added widgets', async ({ comfyPage }) => {
|
|
const loadCheckpointNode = comfyPage.page.locator(
|
|
'css=[data-testid="node-body-4"] > .lg-node-widgets > div'
|
|
)
|
|
await comfyPage.page.evaluate(() => {
|
|
const graph = window.graph as TestGraphAccess
|
|
const node = graph._nodes_by_id['4']
|
|
node.widgets!.push(node.widgets![0])
|
|
})
|
|
await expect(loadCheckpointNode).toHaveCount(2)
|
|
await comfyPage.page.evaluate(() => {
|
|
const graph = window.graph as TestGraphAccess
|
|
const node = graph._nodes_by_id['4']
|
|
node.widgets![2] = node.widgets![0]
|
|
})
|
|
await expect(loadCheckpointNode).toHaveCount(3)
|
|
await comfyPage.page.evaluate(() => {
|
|
const graph = window.graph as TestGraphAccess
|
|
const node = graph._nodes_by_id['4']
|
|
node.widgets!.splice(0, 0, node.widgets![0])
|
|
})
|
|
await expect(loadCheckpointNode).toHaveCount(4)
|
|
})
|
|
|
|
test('Should hide removed widgets', async ({ comfyPage }) => {
|
|
const loadCheckpointNode = comfyPage.page.locator(
|
|
'css=[data-testid="node-body-3"] > .lg-node-widgets > div'
|
|
)
|
|
await comfyPage.page.evaluate(() => {
|
|
const graph = window.graph as TestGraphAccess
|
|
const node = graph._nodes_by_id['3']
|
|
node.widgets!.pop()
|
|
})
|
|
await expect(loadCheckpointNode).toHaveCount(5)
|
|
await comfyPage.page.evaluate(() => {
|
|
const graph = window.graph as TestGraphAccess
|
|
const node = graph._nodes_by_id['3']
|
|
node.widgets!.length--
|
|
})
|
|
await expect(loadCheckpointNode).toHaveCount(4)
|
|
await comfyPage.page.evaluate(() => {
|
|
const graph = window.graph as TestGraphAccess
|
|
const node = graph._nodes_by_id['3']
|
|
node.widgets!.splice(0, 1)
|
|
})
|
|
await expect(loadCheckpointNode).toHaveCount(3)
|
|
})
|
|
})
|