mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-01 22:09:55 +00:00
## Summary
Adds structured test tags to all 54 Playwright test files to enable
flexible test filtering during development and CI.
## Tags Added
| Tag | Count | Purpose |
|-----|-------|---------|
| `@screenshot` | 32 files | Tests with visual assertions
(`toHaveScreenshot`) |
| `@smoke` | 5 files | Quick essential tests for fast validation |
| `@slow` | 5 files | Long-running tests (templates, subgraph,
featureFlags) |
| `@canvas` | 15 files | Canvas/graph rendering tests |
| `@node` | 10 files | Node behavior tests |
| `@ui` | 8 files | UI component tests |
| `@widget` | 5 files | Widget-specific tests |
| `@workflow` | 3 files | Workflow operations |
| `@subgraph` | 1 file | Subgraph functionality |
| `@keyboard` | 2 files | Keyboard shortcuts |
| `@settings` | 2 files | Settings/preferences |
## Usage Examples
```bash
# Quick validation (~16 tests, ~30s)
pnpm test:browser -- --grep @smoke
# Skip slow tests for faster CI feedback
pnpm test:browser -- --grep-invert @slow
# Skip visual tests (useful for local development without snapshots)
pnpm test:browser -- --grep-invert @screenshot
# Run only canvas-related tests
pnpm test:browser -- --grep @canvas
# Combine filters
pnpm test:browser -- --grep @smoke --grep-invert @screenshot
```
## Implementation Details
- Uses Playwright's native tag syntax: `test.describe('Name', { tag:
'@tag' }, ...)`
- Tags inherit from describe blocks to child tests
- Preserves existing project-level tags: `@mobile`, `@2x`, `@0.5x`
- Multiple tags supported: `{ tag: ['@screenshot', '@smoke'] }`
## Test Plan
- [x] All existing tests pass unchanged
- [x] Tag filtering works with `--grep` and `--grep-invert`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8441-test-add-Playwright-test-tags-for-filtering-smoke-slow-screenshot-domains-2f76d73d36508184990ec859c8fd7629)
by [Unito](https://www.unito.io)
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
366 lines
13 KiB
TypeScript
366 lines
13 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Combo text widget', { tag: ['@screenshot', '@widget'] }, () => {
|
|
test('Truncates text when resized', async ({ comfyPage }) => {
|
|
await comfyPage.resizeLoadCheckpointNode(0.2, 1)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'load-checkpoint-resized-min-width.png'
|
|
)
|
|
await comfyPage.closeMenu()
|
|
await comfyPage.resizeKsamplerNode(0.2, 1)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
`ksampler-resized-min-width.png`
|
|
)
|
|
})
|
|
|
|
test("Doesn't truncate when space still available", async ({ comfyPage }) => {
|
|
await comfyPage.resizeEmptyLatentNode(0.8, 0.8)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'empty-latent-resized-80-percent.png'
|
|
)
|
|
})
|
|
|
|
test('Can revert to full text', async ({ comfyPage }) => {
|
|
await comfyPage.resizeLoadCheckpointNode(0.8, 1, true)
|
|
await expect(comfyPage.canvas).toHaveScreenshot('resized-to-original.png')
|
|
})
|
|
|
|
test('should refresh combo values of optional inputs', async ({
|
|
comfyPage
|
|
}) => {
|
|
const getComboValues = async () =>
|
|
comfyPage.page.evaluate(() => {
|
|
return window['app'].graph.nodes
|
|
.find((node) => node.title === 'Node With Optional Combo Input')
|
|
.widgets.find((widget) => widget.name === 'optional_combo_input')
|
|
.options.values
|
|
})
|
|
|
|
await comfyPage.loadWorkflow('inputs/optional_combo_input')
|
|
const initialComboValues = await getComboValues()
|
|
|
|
// Focus canvas
|
|
await comfyPage.page.mouse.click(400, 300)
|
|
|
|
// Press R to trigger refresh
|
|
await comfyPage.page.keyboard.press('r')
|
|
|
|
// Wait for nodes' widgets to be updated
|
|
await comfyPage.page.waitForTimeout(500)
|
|
|
|
const refreshedComboValues = await getComboValues()
|
|
expect(refreshedComboValues).not.toEqual(initialComboValues)
|
|
})
|
|
|
|
test('Should refresh combo values of nodes with v2 combo input spec', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.loadWorkflow('inputs/node_with_v2_combo_input')
|
|
// click canvas to focus
|
|
await comfyPage.page.mouse.click(400, 300)
|
|
// press R to trigger refresh
|
|
await comfyPage.page.keyboard.press('r')
|
|
// wait for nodes' widgets to be updated
|
|
await comfyPage.page.mouse.click(400, 300)
|
|
await comfyPage.nextFrame()
|
|
// get the combo widget's values
|
|
const comboValues = await comfyPage.page.evaluate(() => {
|
|
return window['app'].graph.nodes
|
|
.find((node) => node.title === 'Node With V2 Combo Input')
|
|
.widgets.find((widget) => widget.name === 'combo_input').options.values
|
|
})
|
|
expect(comboValues).toEqual(['A', 'B'])
|
|
})
|
|
})
|
|
|
|
test.describe('Boolean widget', { tag: ['@screenshot', '@widget'] }, () => {
|
|
test('Can toggle', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('widgets/boolean_widget')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('boolean_widget.png')
|
|
const node = (await comfyPage.getFirstNodeRef())!
|
|
const widget = await node.getWidget(0)
|
|
await widget.click()
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'boolean_widget_toggled.png'
|
|
)
|
|
})
|
|
})
|
|
|
|
test.describe('Slider widget', { tag: ['@screenshot', '@widget'] }, () => {
|
|
test('Can drag adjust value', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('inputs/simple_slider')
|
|
const node = (await comfyPage.getFirstNodeRef())!
|
|
const widget = await node.getWidget(0)
|
|
|
|
await comfyPage.page.evaluate(() => {
|
|
const widget = window['app'].graph.nodes[0].widgets[0]
|
|
widget.callback = (value: number) => {
|
|
window['widgetValue'] = value
|
|
}
|
|
})
|
|
await widget.dragHorizontal(50)
|
|
await expect(comfyPage.canvas).toHaveScreenshot('slider_widget_dragged.png')
|
|
|
|
expect(
|
|
await comfyPage.page.evaluate(() => window['widgetValue'])
|
|
).toBeDefined()
|
|
})
|
|
})
|
|
|
|
test.describe('Number widget', { tag: ['@screenshot', '@widget'] }, () => {
|
|
test('Can drag adjust value', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('widgets/seed_widget')
|
|
|
|
const node = (await comfyPage.getFirstNodeRef())!
|
|
const widget = await node.getWidget(0)
|
|
await comfyPage.page.evaluate(() => {
|
|
const widget = window['app'].graph.nodes[0].widgets[0]
|
|
widget.callback = (value: number) => {
|
|
window['widgetValue'] = value
|
|
}
|
|
})
|
|
await widget.dragHorizontal(50)
|
|
await expect(comfyPage.canvas).toHaveScreenshot('seed_widget_dragged.png')
|
|
|
|
expect(
|
|
await comfyPage.page.evaluate(() => window['widgetValue'])
|
|
).toBeDefined()
|
|
})
|
|
})
|
|
|
|
test.describe(
|
|
'Dynamic widget manipulation',
|
|
{ tag: ['@screenshot', '@widget'] },
|
|
() => {
|
|
test('Auto expand node when widget is added dynamically', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.loadWorkflow('nodes/single_ksampler')
|
|
|
|
await comfyPage.page.evaluate(() => {
|
|
window['graph'].nodes[0].addWidget('number', 'new_widget', 10)
|
|
window['graph'].setDirtyCanvas(true, true)
|
|
})
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'ksampler_widget_added.png'
|
|
)
|
|
})
|
|
}
|
|
)
|
|
|
|
test.describe('Image widget', { tag: ['@screenshot', '@widget'] }, () => {
|
|
test('Can load image', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('widgets/load_image_widget')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('load_image_widget.png')
|
|
})
|
|
|
|
test('Can drag and drop image', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('widgets/load_image_widget')
|
|
|
|
// Get position of the load image node
|
|
const nodes = await comfyPage.getNodeRefsByType('LoadImage')
|
|
const loadImageNode = nodes[0]
|
|
const { x, y } = await loadImageNode.getPosition()
|
|
|
|
// Drag and drop image file onto the load image node
|
|
await comfyPage.dragAndDropFile('image32x32.webp', {
|
|
dropPosition: { x, y }
|
|
})
|
|
|
|
// Expect the image preview to change automatically
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'image_preview_drag_and_dropped.png'
|
|
)
|
|
|
|
// Expect the filename combo value to be updated
|
|
const fileComboWidget = await loadImageNode.getWidget(0)
|
|
const filename = await fileComboWidget.getValue()
|
|
expect(filename).toBe('image32x32.webp')
|
|
})
|
|
|
|
test('Can change image by changing the filename combo value', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.loadWorkflow('widgets/load_image_widget')
|
|
const nodes = await comfyPage.getNodeRefsByType('LoadImage')
|
|
const loadImageNode = nodes[0]
|
|
|
|
// Click the combo widget used to select the image filename
|
|
const fileComboWidget = await loadImageNode.getWidget(0)
|
|
await fileComboWidget.click()
|
|
|
|
// Select a new image filename value from the combo context menu
|
|
const comboEntry = comfyPage.page.getByRole('menuitem', {
|
|
name: 'image32x32.webp'
|
|
})
|
|
await comboEntry.click()
|
|
|
|
// Stabilization for the image swap
|
|
await comfyPage.nextFrame()
|
|
|
|
// Expect the image preview to change automatically
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'image_preview_changed_by_combo_value.png'
|
|
)
|
|
|
|
// Expect the filename combo value to be updated
|
|
const filename = await fileComboWidget.getValue()
|
|
expect(filename).toBe('image32x32.webp')
|
|
})
|
|
test('Displays buttons when viewing single image of batch', async ({
|
|
comfyPage
|
|
}) => {
|
|
const [x, y] = await comfyPage.page.evaluate(() => {
|
|
const src =
|
|
"data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='768' height='512' viewBox='0 0 1 1'%3E%3Crect width='1' height='1' stroke='black'/%3E%3C/svg%3E"
|
|
const image1 = new Image()
|
|
image1.src = src
|
|
const image2 = new Image()
|
|
image2.src = src
|
|
const targetNode = graph.nodes[6]
|
|
targetNode.imgs = [image1, image2]
|
|
targetNode.imageIndex = 1
|
|
app.canvas.setDirty(true)
|
|
|
|
const x = targetNode.pos[0] + targetNode.size[0] - 41
|
|
const y = targetNode.pos[1] + targetNode.widgets.at(-1).last_y + 30
|
|
return app.canvasPosToClientPos([x, y])
|
|
})
|
|
|
|
const clip = { x, y, width: 35, height: 35 }
|
|
await expect(comfyPage.page).toHaveScreenshot(
|
|
'image_preview_close_button.png',
|
|
{ clip }
|
|
)
|
|
})
|
|
})
|
|
|
|
test.describe(
|
|
'Animated image widget',
|
|
{ tag: ['@screenshot', '@widget'] },
|
|
() => {
|
|
// https://github.com/Comfy-Org/ComfyUI_frontend/issues/3718
|
|
test.skip('Shows preview of uploaded animated image', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.loadWorkflow('widgets/load_animated_webp')
|
|
|
|
// Get position of the load animated webp node
|
|
const nodes = await comfyPage.getNodeRefsByType(
|
|
'DevToolsLoadAnimatedImageTest'
|
|
)
|
|
const loadAnimatedWebpNode = nodes[0]
|
|
const { x, y } = await loadAnimatedWebpNode.getPosition()
|
|
|
|
// Drag and drop image file onto the load animated webp node
|
|
await comfyPage.dragAndDropFile('animated_webp.webp', {
|
|
dropPosition: { x, y }
|
|
})
|
|
|
|
// Expect the image preview to change automatically
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'animated_image_preview_drag_and_dropped.png'
|
|
)
|
|
|
|
// Move mouse and click on canvas to trigger render
|
|
await comfyPage.page.mouse.click(64, 64)
|
|
|
|
// Expect the image preview to change to the next frame of the animation
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'animated_image_preview_drag_and_dropped_next_frame.png'
|
|
)
|
|
})
|
|
|
|
test('Can drag-and-drop animated webp image', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('widgets/load_animated_webp')
|
|
|
|
// Get position of the load animated webp node
|
|
const nodes = await comfyPage.getNodeRefsByType(
|
|
'DevToolsLoadAnimatedImageTest'
|
|
)
|
|
const loadAnimatedWebpNode = nodes[0]
|
|
const { x, y } = await loadAnimatedWebpNode.getPosition()
|
|
|
|
// Drag and drop image file onto the load animated webp node
|
|
await comfyPage.dragAndDropFile('animated_webp.webp', {
|
|
dropPosition: { x, y },
|
|
waitForUpload: true
|
|
})
|
|
|
|
// Expect the filename combo value to be updated
|
|
const fileComboWidget = await loadAnimatedWebpNode.getWidget(0)
|
|
const filename = await fileComboWidget.getValue()
|
|
expect(filename).toContain('animated_webp.webp')
|
|
})
|
|
|
|
test('Can preview saved animated webp image', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('widgets/save_animated_webp')
|
|
|
|
// Get position of the load animated webp node
|
|
const loadNodes = await comfyPage.getNodeRefsByType(
|
|
'DevToolsLoadAnimatedImageTest'
|
|
)
|
|
const loadAnimatedWebpNode = loadNodes[0]
|
|
const { x, y } = await loadAnimatedWebpNode.getPosition()
|
|
|
|
// Drag and drop image file onto the load animated webp node
|
|
await comfyPage.dragAndDropFile('animated_webp.webp', {
|
|
dropPosition: { x, y }
|
|
})
|
|
await comfyPage.nextFrame()
|
|
|
|
// Get the SaveAnimatedWEBP node
|
|
const saveNodes = await comfyPage.getNodeRefsByType('SaveAnimatedWEBP')
|
|
const saveAnimatedWebpNode = saveNodes[0]
|
|
if (!saveAnimatedWebpNode)
|
|
throw new Error('SaveAnimatedWEBP node not found')
|
|
|
|
// Simulate the graph executing
|
|
await comfyPage.page.evaluate(
|
|
([loadId, saveId]) => {
|
|
// Set the output of the SaveAnimatedWEBP node to equal the loader node's image
|
|
window['app'].nodeOutputs[saveId] = window['app'].nodeOutputs[loadId]
|
|
app.canvas.setDirty(true)
|
|
},
|
|
[loadAnimatedWebpNode.id, saveAnimatedWebpNode.id]
|
|
)
|
|
await expect(
|
|
comfyPage.page.locator('.dom-widget').locator('img')
|
|
).toHaveCount(2)
|
|
})
|
|
}
|
|
)
|
|
|
|
test.describe('Load audio widget', { tag: ['@screenshot', '@widget'] }, () => {
|
|
test('Can load audio', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('widgets/load_audio_widget')
|
|
// Wait for the audio widget to be rendered in the DOM
|
|
await comfyPage.page.waitForSelector('.comfy-audio', { state: 'attached' })
|
|
await comfyPage.nextFrame()
|
|
await expect(comfyPage.canvas).toHaveScreenshot('load_audio_widget.png')
|
|
})
|
|
})
|
|
|
|
test.describe('Unserialized widgets', { tag: '@widget' }, () => {
|
|
test('Unserialized widgets values do not mark graph as modified', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Add workflow w/ LoadImage node, which contains file upload and image preview widgets (not serialized)
|
|
await comfyPage.loadWorkflow('widgets/load_image_widget')
|
|
|
|
// Move mouse and click to trigger the `graphEqual` check in `changeTracker.ts`
|
|
await comfyPage.page.mouse.move(10, 10)
|
|
await comfyPage.page.mouse.click(10, 10)
|
|
|
|
// Expect the graph to not be modified
|
|
expect(await comfyPage.isCurrentWorkflowModified()).toBe(false)
|
|
})
|
|
})
|