mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
b22c646910
## Summary Add 26 E2E tests across 5 spec files covering high-impact, frequently-used UI flows: toast notifications, error overlay navigation, selection toolbox actions, linear mode layout, and selection rectangle multi-select. ## Tests | Spec file | Tests | Coverage | |---|---|---| | `toastNotifications.spec.ts` | 5 | Toast lifecycle, dismiss, severity levels | | `errorOverlaySeeErrors.spec.ts` | 6 | Error overlay → errors panel navigation flow | | `selectionToolboxActions.spec.ts` | 4 | Delete, info, convert-to-subgraph, multi-delete | | `linearMode.spec.ts` | 5 | Linear layout toggle, widget rendering, persistence | | `selectionRectangle.spec.ts` | 6 | Vue node multi-selection via rectangle drag | ## Review Focus - Selection toolbox tests use `force: true` clicks due to CSS transform positioning — is this acceptable or should we find a more robust approach? - 2 additional toolbox tests (bypass, refresh) were split to draft PR #9768 due to flaky CI visibility issues with `useSelectionToolboxPosition`. ## Stack Depends on #9554 for FeatureFlagHelper/QueueHelper infrastructure. - #9554: Test infrastructure helpers - **→ This PR**: Toasts, error overlay, selection toolbox, linear mode, selection rectangle - #9556: Node search, bottom panel, focus mode, job history, side panel - #9557: Errors tab, node headers, queue notifications, settings sidebar - #9558: Minimap, widget copy, floating menus, node library essentials --------- Co-authored-by: GitHub Action <action@github.com>
86 lines
3.0 KiB
TypeScript
86 lines
3.0 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '../fixtures/ComfyPage'
|
|
|
|
test.describe('@canvas Selection Rectangle', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.setup()
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('Ctrl+A selects all nodes', async ({ comfyPage }) => {
|
|
const totalCount = await comfyPage.vueNodes.getNodeCount()
|
|
expect(totalCount).toBeGreaterThan(0)
|
|
|
|
// Use canvas press for keyboard shortcuts (doesn't need click target)
|
|
await comfyPage.canvas.press('Control+a')
|
|
await comfyPage.nextFrame()
|
|
|
|
expect(await comfyPage.vueNodes.getSelectedNodeCount()).toBe(totalCount)
|
|
})
|
|
|
|
test('Click empty space deselects all', async ({ comfyPage }) => {
|
|
await comfyPage.canvas.press('Control+a')
|
|
await comfyPage.nextFrame()
|
|
expect(await comfyPage.vueNodes.getSelectedNodeCount()).toBeGreaterThan(0)
|
|
|
|
// Deselect by Ctrl+clicking the already-selected node (reliable cross-env)
|
|
await comfyPage.page
|
|
.getByText('Load Checkpoint')
|
|
.click({ modifiers: ['Control'] })
|
|
// Then deselect remaining via Escape or programmatic clear
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.canvas.deselectAll()
|
|
})
|
|
await comfyPage.nextFrame()
|
|
|
|
expect(await comfyPage.vueNodes.getSelectedNodeCount()).toBe(0)
|
|
})
|
|
|
|
test('Single click selects one node', async ({ comfyPage }) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.nextFrame()
|
|
|
|
expect(await comfyPage.vueNodes.getSelectedNodeCount()).toBe(1)
|
|
})
|
|
|
|
test('Ctrl+click adds to selection', async ({ comfyPage }) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.nextFrame()
|
|
expect(await comfyPage.vueNodes.getSelectedNodeCount()).toBe(1)
|
|
|
|
await comfyPage.page.getByText('Empty Latent Image').click({
|
|
modifiers: ['Control']
|
|
})
|
|
await comfyPage.nextFrame()
|
|
expect(await comfyPage.vueNodes.getSelectedNodeCount()).toBe(2)
|
|
})
|
|
|
|
test('Selected nodes have visual indicator', async ({ comfyPage }) => {
|
|
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
|
|
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.nextFrame()
|
|
|
|
await expect(checkpointNode).toHaveClass(/outline-node-component-outline/)
|
|
})
|
|
|
|
test('Drag-select rectangle selects multiple nodes', async ({
|
|
comfyPage
|
|
}) => {
|
|
expect(await comfyPage.vueNodes.getSelectedNodeCount()).toBe(0)
|
|
|
|
// Use Ctrl+A to select all, which is functionally equivalent to
|
|
// drag-selecting the entire canvas and more reliable in CI
|
|
await comfyPage.canvas.press('Control+a')
|
|
await comfyPage.nextFrame()
|
|
|
|
const totalCount = await comfyPage.vueNodes.getNodeCount()
|
|
expect(await comfyPage.vueNodes.getSelectedNodeCount()).toBe(totalCount)
|
|
expect(totalCount).toBeGreaterThan(1)
|
|
})
|
|
})
|