mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 19:09:52 +00:00
bc4549244e
## Summary UseNewMenu has been defaulted to Top in the app for over a year; Playwright’s test default lagged behind. This PR aligns the test default with reality and keeps legacy specs stable. ## Changes - tests(e2e): default to 'Top' via fixture; specs that previously relied on the old implicit default now explicitly set 'Comfy.UseNewMenu' to 'Disabled'. - docs(browser-tests): remove outdated README note suggesting tests set 'Top' manually. ## Review Focus - Intentional uses of 'Top' and 'Bottom' remain unchanged. - Confirm ComfyPage default remains 'Top' (see browser_tests/fixtures/ComfyPage.ts). ## Screenshots (if applicable) N/A ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5746-test-e2e-align-test-default-menu-to-Top-make-legacy-specs-explicit-2786d73d365081218d06c1346f3ae18e) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
49 lines
1.9 KiB
TypeScript
49 lines
1.9 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Execution', () => {
|
|
test('Report error on unconnected slot', async ({ comfyPage }) => {
|
|
await comfyPage.disconnectEdge()
|
|
await comfyPage.clickEmptySpace()
|
|
|
|
await comfyPage.executeCommand('Comfy.QueuePrompt')
|
|
await expect(comfyPage.page.locator('.comfy-error-report')).toBeVisible()
|
|
await comfyPage.page.locator('.p-dialog-close-button').click()
|
|
await comfyPage.page.locator('.comfy-error-report').waitFor({
|
|
state: 'hidden'
|
|
})
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'execution-error-unconnected-slot.png'
|
|
)
|
|
})
|
|
})
|
|
|
|
test.describe('Execute to selected output nodes', () => {
|
|
test('Execute to selected output nodes', async ({ comfyPage }) => {
|
|
await comfyPage.loadWorkflow('execution/partial_execution')
|
|
const input = await comfyPage.getNodeRefById(3)
|
|
const output1 = await comfyPage.getNodeRefById(1)
|
|
const output2 = await comfyPage.getNodeRefById(4)
|
|
expect(await (await input.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output1.getWidget(0)).getValue()).toBe('')
|
|
expect(await (await output2.getWidget(0)).getValue()).toBe('')
|
|
|
|
await output1.click('title')
|
|
|
|
await comfyPage.executeCommand('Comfy.QueueSelectedOutputNodes')
|
|
// @note: Wait for the execution to finish. We might want to move to a more
|
|
// reliable way to wait for the execution to finish. Workflow in this test
|
|
// is simple enough that this is fine for now.
|
|
await comfyPage.page.waitForTimeout(200)
|
|
|
|
expect(await (await input.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output1.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output2.getWidget(0)).getValue()).toBe('')
|
|
})
|
|
})
|