mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-24 14:45:36 +00:00
0ef98de8eb
## Summary The help icon (lucide circle-help) next to the credits balance in the cloud user popover was a bare `<i>` with `v-tooltip` and `cursor-help`. PrimeVue tooltip on a bare `<i>` did not fire reliably and the icon had no focus/keyboard semantics, so users saw "no hover action and not clickable". Wrap the icon in `<Button variant="muted-textonly" size="icon-sm">`, matching the existing pattern in `InfoButton.vue` and `MissingPackGroupRow.vue`. Same change applied to `CurrentUserPopoverLegacy.vue` and `CurrentUserPopoverWorkspace.vue`, which shared the broken pattern. - Fixes FE-617 - https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1778191473621829 ## Red-Green CI Verification The branch was force-pushed back to the test-only commit so CI could run against it, then restored to the fix commit. | Commit | CI: Tests Unit | Outcome | |--------|---------------|---------| | `test:` (e7c83abd0) — adds the regression test only | https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/25532935842 | failed — `Unable to find an element by: [data-testid="credits-info-button"]` | | `fix:` (64ec4cda4) — wraps the icon in `<Button>` | https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/25533224195 | passed | <img width="434" height="364" alt="Screenshot 2026-05-08 at 5 32 47 PM" src="https://github.com/user-attachments/assets/d3088b90-813f-4a0f-ba35-0f040fc79a6a" /> ## Test Plan - [x] Component test asserts the icon renders as an interactive `<button>` with the unified-credits tooltip text as `aria-label` - [x] Red CI failed with the expected error on the test-only commit - [x] Green CI passed on the fix commit - [ ] Manual verification on `pnpm dev:cloud` — hover the help icon next to the credits balance and confirm the unification tooltip appears