mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-10 07:30:08 +00:00
8aa4e36fd5
## Summary Extracts error-related state and logic from `executionStore` into a dedicated `executionErrorStore` for better separation of concerns. ## Changes - **New store**: `executionErrorStore` with all error state (`lastNodeErrors`, `lastExecutionError`, `lastPromptError`), computed properties (`hasAnyError`, `totalErrorCount`, `activeGraphErrorNodeIds`), and UI state (`isErrorOverlayOpen`, `showErrorOverlay`, `dismissErrorOverlay`) - **Moved util**: `executionIdToNodeLocatorId` extracted to `graphTraversalUtil`, reusing `traverseSubgraphPath` and accepting `rootGraph` as parameter - **Updated consumers**: 12 files updated to import from `executionErrorStore` - **Backward compat**: Deprecated getters retained in `ComfyApp` for extension compatibility ## Review Focus - Deprecated getters in `app.ts` — can be removed in a future breaking-change PR once extension authors migrate ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9060-refactor-Extract-executionErrorStore-from-executionStore-30e6d73d36508101973de835ab6b199f) by [Unito](https://www.unito.io)
106 lines
3.3 KiB
Vue
106 lines
3.3 KiB
Vue
<template>
|
|
<Transition
|
|
enter-active-class="transition-all duration-300 ease-out"
|
|
enter-from-class="-translate-y-3 opacity-0"
|
|
enter-to-class="translate-y-0 opacity-100"
|
|
>
|
|
<div v-if="isVisible" class="flex justify-end w-full pointer-events-none">
|
|
<div
|
|
role="alert"
|
|
aria-live="assertive"
|
|
data-testid="error-overlay"
|
|
class="pointer-events-auto flex w-80 min-w-72 flex-col overflow-hidden rounded-lg border border-interface-stroke bg-comfy-menu-bg shadow-interface transition-colors duration-200 ease-in-out"
|
|
>
|
|
<!-- Header -->
|
|
<div class="flex h-12 items-center gap-2 px-4">
|
|
<span class="flex-1 text-sm font-bold text-destructive-background">
|
|
{{ errorCountLabel }}
|
|
</span>
|
|
<Button
|
|
variant="muted-textonly"
|
|
size="icon-sm"
|
|
:aria-label="t('g.close')"
|
|
@click="dismiss"
|
|
>
|
|
<i class="icon-[lucide--x] block size-5 leading-none" />
|
|
</Button>
|
|
</div>
|
|
|
|
<!-- Body -->
|
|
<div class="px-4 pb-3">
|
|
<ul class="m-0 flex list-none flex-col gap-1.5 p-0">
|
|
<li
|
|
v-for="(message, idx) in groupedErrorMessages"
|
|
:key="idx"
|
|
class="flex items-baseline gap-2 text-sm leading-snug text-muted-foreground min-w-0"
|
|
>
|
|
<span
|
|
class="mt-1.5 size-1 shrink-0 rounded-full bg-muted-foreground"
|
|
/>
|
|
<span class="break-words line-clamp-3 whitespace-pre-wrap">{{
|
|
message
|
|
}}</span>
|
|
</li>
|
|
</ul>
|
|
</div>
|
|
|
|
<!-- Footer -->
|
|
<div class="flex items-center justify-end gap-4 px-4 py-3">
|
|
<Button variant="muted-textonly" size="unset" @click="dismiss">
|
|
{{ t('g.dismiss') }}
|
|
</Button>
|
|
<Button variant="secondary" size="lg" @click="seeErrors">
|
|
{{ t('errorOverlay.seeErrors') }}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</Transition>
|
|
</template>
|
|
|
|
<script setup lang="ts">
|
|
import { computed, ref } from 'vue'
|
|
import { useI18n } from 'vue-i18n'
|
|
import { storeToRefs } from 'pinia'
|
|
|
|
import Button from '@/components/ui/button/Button.vue'
|
|
import { useExecutionErrorStore } from '@/stores/executionErrorStore'
|
|
import { useRightSidePanelStore } from '@/stores/workspace/rightSidePanelStore'
|
|
import { useCanvasStore } from '@/renderer/core/canvas/canvasStore'
|
|
import { useErrorGroups } from '@/components/rightSidePanel/errors/useErrorGroups'
|
|
|
|
const { t } = useI18n()
|
|
const executionErrorStore = useExecutionErrorStore()
|
|
const rightSidePanelStore = useRightSidePanelStore()
|
|
const canvasStore = useCanvasStore()
|
|
|
|
const { totalErrorCount, isErrorOverlayOpen } = storeToRefs(executionErrorStore)
|
|
const { groupedErrorMessages } = useErrorGroups(ref(''), t)
|
|
|
|
const errorCountLabel = computed(() =>
|
|
t(
|
|
'errorOverlay.errorCount',
|
|
{ count: totalErrorCount.value },
|
|
totalErrorCount.value
|
|
)
|
|
)
|
|
|
|
const isVisible = computed(
|
|
() => isErrorOverlayOpen.value && totalErrorCount.value > 0
|
|
)
|
|
|
|
function dismiss() {
|
|
executionErrorStore.dismissErrorOverlay()
|
|
}
|
|
|
|
function seeErrors() {
|
|
if (canvasStore.canvas) {
|
|
canvasStore.canvas.deselectAll()
|
|
canvasStore.updateSelectedItems()
|
|
}
|
|
|
|
rightSidePanelStore.openPanel('errors')
|
|
executionErrorStore.dismissErrorOverlay()
|
|
}
|
|
</script>
|