mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-14 17:37:46 +00:00
5167a511ce
## Summary - Fixes a bug where widgets marked as `advanced` were always visible, ignoring the "Always show advanced widgets on all nodes" setting - Root cause: `extractWidgetDisplayOptions` in `useGraphNodeManager.ts` read `widget.advanced` (always `undefined` on BaseWidget) instead of `widget.options?.advanced` (where `litegraphService` actually sets the flag) - Consistent with how `hidden` is already read from `widget.options.hidden` on the adjacent line ## Test plan - [ ] Load a node with advanced inputs (e.g. `LTXVScheduler`) - [ ] Verify `max_shift`, `base_shift`, `stretch`, `terminal` are hidden when "Always show advanced widgets on all nodes" is disabled - [ ] Verify they become visible when the setting is enabled or the per-node toggle is clicked - [ ] Verify the advanced toggle button appears on nodes with advanced widgets 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9857-fix-advanced-widgets-always-visible-regardless-of-setting-3226d73d36508132b338d098fbf19433) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
103 lines
3.3 KiB
TypeScript
103 lines
3.3 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '../../../fixtures/ComfyPage'
|
|
|
|
test.describe('Advanced Widget Visibility', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.Node.AlwaysShowAdvancedWidgets',
|
|
false
|
|
)
|
|
|
|
// Add a ModelSamplingFlux node which has both advanced (max_shift,
|
|
// base_shift) and non-advanced (width, height) widgets.
|
|
await comfyPage.page.evaluate(() => {
|
|
const node = window.LiteGraph!.createNode('ModelSamplingFlux')!
|
|
node.pos = [500, 200]
|
|
window.app!.graph.add(node)
|
|
})
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
function getNode(
|
|
comfyPage: Parameters<Parameters<typeof test>[2]>[0]['comfyPage']
|
|
) {
|
|
return comfyPage.vueNodes.getNodeByTitle('ModelSamplingFlux')
|
|
}
|
|
|
|
function getWidgets(
|
|
comfyPage: Parameters<Parameters<typeof test>[2]>[0]['comfyPage']
|
|
) {
|
|
return getNode(comfyPage).locator('.lg-node-widget')
|
|
}
|
|
|
|
test('should hide advanced widgets by default', async ({ comfyPage }) => {
|
|
const node = getNode(comfyPage)
|
|
const widgets = getWidgets(comfyPage)
|
|
|
|
// Non-advanced widgets (width, height) should be visible
|
|
await expect(widgets).toHaveCount(2)
|
|
await expect(node.getByLabel('width', { exact: true })).toBeVisible()
|
|
await expect(node.getByLabel('height', { exact: true })).toBeVisible()
|
|
|
|
// Advanced widgets should not be rendered
|
|
await expect(
|
|
node.getByLabel('max_shift', { exact: true })
|
|
).not.toBeVisible()
|
|
await expect(
|
|
node.getByLabel('base_shift', { exact: true })
|
|
).not.toBeVisible()
|
|
|
|
// "Show advanced inputs" button should be present
|
|
await expect(node.getByText('Show advanced inputs')).toBeVisible()
|
|
})
|
|
|
|
test('should show advanced widgets when per-node toggle is clicked', async ({
|
|
comfyPage
|
|
}) => {
|
|
const node = getNode(comfyPage)
|
|
const widgets = getWidgets(comfyPage)
|
|
|
|
await expect(widgets).toHaveCount(2)
|
|
|
|
// Click the toggle button to show advanced widgets
|
|
await node.getByText('Show advanced inputs').click()
|
|
|
|
await expect(widgets).toHaveCount(4)
|
|
await expect(node.getByLabel('max_shift', { exact: true })).toBeVisible()
|
|
await expect(node.getByLabel('base_shift', { exact: true })).toBeVisible()
|
|
|
|
// Button text should change to "Hide advanced inputs"
|
|
await expect(node.getByText('Hide advanced inputs')).toBeVisible()
|
|
|
|
// Click again to hide
|
|
await node.getByText('Hide advanced inputs').click()
|
|
await expect(widgets).toHaveCount(2)
|
|
})
|
|
|
|
test('should show advanced widgets when global setting is enabled', async ({
|
|
comfyPage
|
|
}) => {
|
|
const node = getNode(comfyPage)
|
|
const widgets = getWidgets(comfyPage)
|
|
|
|
await expect(widgets).toHaveCount(2)
|
|
|
|
// Enable the global setting
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.Node.AlwaysShowAdvancedWidgets',
|
|
true
|
|
)
|
|
|
|
// All 4 widgets should now be visible
|
|
await expect(widgets).toHaveCount(4)
|
|
await expect(node.getByLabel('max_shift', { exact: true })).toBeVisible()
|
|
await expect(node.getByLabel('base_shift', { exact: true })).toBeVisible()
|
|
|
|
// The toggle button should not be shown when global setting is active
|
|
await expect(node.getByText('Show advanced inputs')).not.toBeVisible()
|
|
})
|
|
})
|