mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-14 09:27:41 +00:00
4e85537b15
## Summary - Fixes #9319 - Add [fast-check](https://github.com/dubzzz/fast-check) property-based testing with FSM (Finite State Machine) traversal to automatically explore state combinations in the workflow persistence system - Fix a real bug in `saveDraft()` discovered by the FSM test: orphan cleanup in `loadIndex()` could delete a just-written payload when the in-memory cache was empty ## Why this is needed #9317 exposed a class of bug where two independently correct changes interact to cause workflow loss. Conventional unit tests verify specific, hand-picked scenarios and cannot catch these cross-PR interaction bugs. ### AS IS (before) | Aspect | Status | |---|---| | Testing approach | Example-based: developer picks specific inputs and expected outputs | | State coverage | Only explicitly written scenarios are tested | | Cross-interaction bugs | Not detectable — each test runs one isolated path | | Bug in `saveDraft` | Undetected — `loadIndex()` orphan cleanup could delete a just-written payload after `reset()` | ### TO BE (after) | Aspect | Status | |---|---| | Testing approach | Property-based: fast-check generates **200 random command sequences** per run | | State coverage | Random exploration of `SaveDraft → GetDraft → RemoveDraft → MoveDraft → GetMostRecentPath → Reset` combinations | | Cross-interaction bugs | Detected automatically — fast-check shrinks failing sequences to minimal reproductions | | Bug in `saveDraft` | Found and fixed — `loadIndex()` now runs **before** `writePayload()` to prevent orphan cleanup race | ## What fast-check does fast-check is a property-based testing library. Instead of testing "does this specific input produce this specific output?", it tests "does this **property** hold for **all possible inputs**?" For FSM testing specifically, fast-check: 1. Takes a set of **commands** (SaveDraft, GetDraft, RemoveDraft, MoveDraft, GetMostRecentPath, Reset) 2. Generates **random sequences** of these commands 3. Runs each sequence against both a **model** (simplified oracle) and the **real system** (store + localStorage) 4. Verifies **invariants** after every mutating command (index/payload consistency, no orphans, LRU correctness, model agreement) 5. When a failure is found, **shrinks** the sequence to the minimal reproduction Example: the bug this PR fixes was shrunk to just 4 commands: ``` SaveDraft(d.json) → RemoveDraft(d.json) → Reset() → SaveDraft(a.json) ✗ ``` ## Changes | File | Change | |---|---| | `package.json` / `pnpm-workspace.yaml` | Add `fast-check` devDependency | | `draftCacheV2.property.test.ts` | 7 property tests for pure index functions | | `workflowDraftStoreV2.fsm.test.ts` | FSM test: 6 commands, invariant checking, 200 runs | | `workflowDraftStoreV2.ts` | Fix: move `loadIndex()` before `writePayload()` in `saveDraft()` | ## Test plan - [x] `pnpm test:unit` — all 117 persistence tests pass (including 7 property + 1 FSM) - [x] `pnpm typecheck` — clean - [x] `pnpm lint` — clean - [x] Pre-commit hooks pass (format, lint, typecheck) - [x] Pre-push hook passes (knip) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9370-test-add-property-based-FSM-tests-for-workflow-persistence-3196d73d3650813daa98cdd8bef7e975) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: GitHub Action <action@github.com>
150 lines
3.6 KiB
YAML
150 lines
3.6 KiB
YAML
packages:
|
|
- apps/**
|
|
- packages/**
|
|
|
|
catalog:
|
|
'@alloc/quick-lru': ^5.2.0
|
|
'@comfyorg/comfyui-electron-types': 0.6.2
|
|
'@eslint/js': ^9.39.1
|
|
'@formkit/auto-animate': ^0.9.0
|
|
'@iconify-json/lucide': ^1.1.178
|
|
'@iconify/json': ^2.2.380
|
|
'@iconify/tailwind4': ^1.2.0
|
|
'@iconify/utils': ^3.1.0
|
|
'@intlify/eslint-plugin-vue-i18n': ^4.1.1
|
|
'@lobehub/i18n-cli': ^1.26.1
|
|
'@nx/eslint': 22.5.2
|
|
'@nx/playwright': 22.5.2
|
|
'@nx/storybook': 22.5.2
|
|
'@nx/vite': 22.5.2
|
|
'@pinia/testing': ^1.0.3
|
|
'@playwright/test': ^1.58.1
|
|
'@primeuix/forms': 0.0.2
|
|
'@primeuix/styled': 0.3.2
|
|
'@primeuix/utils': ^0.3.2
|
|
'@primevue/core': ^4.2.5
|
|
'@primevue/forms': ^4.2.5
|
|
'@primevue/icons': 4.2.5
|
|
'@primevue/themes': ^4.2.5
|
|
'@sentry/vite-plugin': ^4.6.0
|
|
'@sentry/vue': ^10.32.1
|
|
'@sparkjsdev/spark': ^0.1.10
|
|
'@storybook/addon-docs': ^10.2.10
|
|
'@storybook/addon-mcp': 0.1.6
|
|
'@storybook/vue3': ^10.2.10
|
|
'@storybook/vue3-vite': ^10.2.10
|
|
'@tailwindcss/vite': ^4.2.0
|
|
'@tiptap/core': ^2.27.2
|
|
'@tiptap/extension-link': ^2.27.2
|
|
'@tiptap/extension-table': ^2.27.2
|
|
'@tiptap/extension-table-cell': ^2.27.2
|
|
'@tiptap/extension-table-header': ^2.27.2
|
|
'@tiptap/extension-table-row': ^2.27.2
|
|
'@tiptap/pm': 2.27.2
|
|
'@tiptap/starter-kit': ^2.27.2
|
|
'@types/fs-extra': ^11.0.4
|
|
'@types/jsdom': ^21.1.7
|
|
'@types/node': ^24.1.0
|
|
'@types/semver': ^7.7.0
|
|
'@types/three': ^0.169.0
|
|
'@vitejs/plugin-vue': ^6.0.0
|
|
'@vitest/coverage-v8': ^4.0.16
|
|
'@vitest/ui': ^4.0.16
|
|
'@vue/test-utils': ^2.4.6
|
|
'@vueuse/core': ^14.2.0
|
|
'@vueuse/integrations': ^14.2.0
|
|
'@webgpu/types': ^0.1.66
|
|
algoliasearch: ^5.21.0
|
|
axios: ^1.13.5
|
|
cross-env: ^10.1.0
|
|
cva: 1.0.0-beta.4
|
|
dompurify: ^3.3.1
|
|
dotenv: ^16.4.5
|
|
eslint: ^9.39.1
|
|
eslint-config-prettier: ^10.1.8
|
|
eslint-import-resolver-typescript: ^4.4.4
|
|
eslint-plugin-better-tailwindcss: ^4.3.1
|
|
eslint-plugin-import-x: ^4.16.1
|
|
eslint-plugin-oxlint: 1.25.0
|
|
eslint-plugin-storybook: ^10.2.10
|
|
eslint-plugin-unused-imports: ^4.3.0
|
|
eslint-plugin-vue: ^10.6.2
|
|
fast-check: ^4.5.3
|
|
firebase: ^11.6.0
|
|
glob: ^13.0.6
|
|
globals: ^16.5.0
|
|
happy-dom: ^20.0.11
|
|
husky: ^9.1.7
|
|
jiti: 2.6.1
|
|
jsdom: ^27.4.0
|
|
jsonata: ^2.1.0
|
|
jsondiffpatch: ^0.7.3
|
|
knip: ^5.75.1
|
|
lint-staged: ^16.2.7
|
|
markdown-table: ^3.0.4
|
|
mixpanel-browser: ^2.71.0
|
|
nx: 22.5.2
|
|
oxfmt: ^0.34.0
|
|
oxlint: ^1.49.0
|
|
oxlint-tsgolint: ^0.14.2
|
|
picocolors: ^1.1.1
|
|
pinia: ^3.0.4
|
|
postcss-html: ^1.8.0
|
|
posthog-js: ^1.358.1
|
|
pretty-bytes: ^7.1.0
|
|
primeicons: ^7.0.0
|
|
primevue: ^4.2.5
|
|
reka-ui: ^2.5.0
|
|
rollup-plugin-visualizer: ^6.0.4
|
|
storybook: ^10.2.10
|
|
stylelint: ^16.26.1
|
|
tailwindcss: ^4.2.0
|
|
tailwindcss-primeui: ^0.6.1
|
|
tsx: ^4.15.6
|
|
tw-animate-css: ^1.3.8
|
|
typegpu: ^0.8.2
|
|
typescript: ^5.9.3
|
|
typescript-eslint: ^8.49.0
|
|
unplugin-icons: ^22.5.0
|
|
unplugin-typegpu: 0.8.0
|
|
unplugin-vue-components: ^30.0.0
|
|
vite: 8.0.0-beta.13
|
|
vite-plugin-dts: ^4.5.4
|
|
vite-plugin-html: ^3.2.2
|
|
vite-plugin-vue-devtools: ^8.0.0
|
|
vitest: ^4.0.16
|
|
vue: ^3.5.13
|
|
vue-component-type-helpers: ^3.2.1
|
|
vue-eslint-parser: ^10.4.0
|
|
vue-i18n: ^9.14.5
|
|
vue-router: ^4.4.3
|
|
vue-tsc: ^3.2.5
|
|
vuefire: ^3.2.1
|
|
wwobjloader2: ^6.2.1
|
|
yjs: ^13.6.27
|
|
zod: ^3.23.8
|
|
zod-to-json-schema: ^3.24.1
|
|
zod-validation-error: ^3.3.0
|
|
|
|
cleanupUnusedCatalogs: true
|
|
|
|
ignoredBuiltDependencies:
|
|
- '@firebase/util'
|
|
- protobufjs
|
|
- unrs-resolver
|
|
- vue-demi
|
|
|
|
onlyBuiltDependencies:
|
|
- '@playwright/browser-chromium'
|
|
- '@playwright/browser-firefox'
|
|
- '@playwright/browser-webkit'
|
|
- '@sentry/cli'
|
|
- '@tailwindcss/oxide'
|
|
- esbuild
|
|
- nx
|
|
- oxc-resolver
|
|
|
|
overrides:
|
|
'@tiptap/pm': 2.27.2
|
|
'@types/eslint': '-'
|