mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
7823cfc83e
## Summary Add 30 E2E tests across 5 spec files covering medium-impact UI interactions: node search V2, bottom panel logs, focus mode, job history actions, and right side panel tabs. ## Tests | Spec file | Tests | Coverage | |---|---|---| | `nodeSearchBoxV2Extended.spec.ts` | 6 | V2 search filtering, keyboard navigation, category display | | `bottomPanelLogs.spec.ts` | 6 | Bottom panel toggle, logs tab, xterm terminal rendering | | `focusMode.spec.ts` | 6 | Focus mode hide/show UI chrome, sidebar/menu visibility | | `jobHistoryActions.spec.ts` | 6 | More options popover, docked history panel, queue interactions | | `rightSidePanelTabs.spec.ts` | 6 | Properties panel, node details, search from side panel | ## Review Focus - Bottom panel logs tests interact with xterm.js — the approach uses terminal container visibility rather than text content assertions. Is this the right level of testing? - Focus mode tests verify UI element hiding — they check element count/visibility rather than visual regression. Appropriate? ## Stack Depends on #9554 for FeatureFlagHelper/QueueHelper infrastructure. - #9554: Test infrastructure helpers - #9555: Toasts, error overlay, selection toolbox, linear mode, selection rectangle - **→ This PR**: Node search, bottom panel, focus mode, job history, side panel - #9557: Errors tab, node headers, queue notifications, settings sidebar - #9558: Minimap, widget copy, floating menus, node library essentials
103 lines
3.0 KiB
TypeScript
103 lines
3.0 KiB
TypeScript
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '../fixtures/ComfyPage'
|
|
|
|
test.describe('Bottom Panel Logs', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test('should open bottom panel via toggle button', async ({ comfyPage }) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await expect(bottomPanel.root).not.toBeVisible()
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
})
|
|
|
|
test('should show Logs tab when terminal panel opens', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
})
|
|
|
|
test('should close bottom panel via toggle button', async ({ comfyPage }) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).not.toBeVisible()
|
|
})
|
|
|
|
test('should switch between shortcuts and terminal panels', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.keyboardShortcutsButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
await expect(
|
|
comfyPage.page.locator('[id*="tab_shortcuts-essentials"]')
|
|
).toBeVisible()
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
await expect(
|
|
comfyPage.page.locator('[id*="tab_shortcuts-essentials"]')
|
|
).not.toBeVisible()
|
|
})
|
|
|
|
test('should persist Logs tab content in bottom panel', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
|
|
const isAlreadyActive =
|
|
(await logsTab.getAttribute('aria-selected')) === 'true'
|
|
if (!isAlreadyActive) {
|
|
await logsTab.click()
|
|
}
|
|
|
|
const xtermContainer = bottomPanel.root.locator('.xterm')
|
|
await expect(xtermContainer).toBeVisible()
|
|
})
|
|
|
|
test('should render xterm container in terminal panel', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
|
|
const isAlreadyActive =
|
|
(await logsTab.getAttribute('aria-selected')) === 'true'
|
|
if (!isAlreadyActive) {
|
|
await logsTab.click()
|
|
}
|
|
|
|
const xtermScreen = bottomPanel.root.locator('.xterm, .xterm-screen')
|
|
await expect(xtermScreen.first()).toBeVisible()
|
|
})
|
|
})
|